Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbdC0ROx (ORCPT ); Mon, 27 Mar 2017 13:14:53 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:38319 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbdC0ROn (ORCPT ); Mon, 27 Mar 2017 13:14:43 -0400 Date: Mon, 27 Mar 2017 10:14:21 -0700 From: Christoph Hellwig To: NeilBrown Cc: Christoph Hellwig , Ming Lei , Jens Axboe , linux-block@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, Alasdair Kergon , Mike Snitzer , Shaohua Li , linux-kernel@vger.kernel.org, "Martin K . Petersen" Subject: Re: [PATCH v3] block: trace completion of all bios. Message-ID: <20170327171421.GA464@infradead.org> References: <877f3iave6.fsf@notabene.neil.brown.name> <20170322125149.GA29606@infradead.org> <87shm4a4lt.fsf@notabene.neil.brown.name> <20170323104331.GA16903@ming.t460p> <87fui3a65o.fsf@notabene.neil.brown.name> <20170327090308.GA11757@infradead.org> <87zig76oca.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zig76oca.fsf@notabene.neil.brown.name> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 12 On Mon, Mar 27, 2017 at 08:49:57PM +1100, NeilBrown wrote: > On Mon, Mar 27 2017, Christoph Hellwig wrote: > > > I don't really like the flag at all. I'd much prefer a __bio_endio > > with a 'bool trace' flag. Also please remove the manual tracing in > > dm.ċ. Once that is done I suspect we can also remove the > > block_bio_complete export. > > Can you say why you don't like it? It uses up a precious bit in the bio for something that should be state that can be determined in the caller at compile time.