Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbdC0Roe (ORCPT ); Mon, 27 Mar 2017 13:44:34 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34841 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdC0Ro1 (ORCPT ); Mon, 27 Mar 2017 13:44:27 -0400 From: Dmitry Monakhov To: LKML Subject: scsi_debug: shared dev context, BUG or FEATURE? CC: dgilbert@interlog.com, martin.petersen@oracle.com Date: Mon, 27 Mar 2017 20:35:58 +0300 Message-ID: <87tw6e4o75.fsf@dmlp.sw.ru> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 13 Hi scsi_debug has very strange structure from one point it supports dynamic number of devices but from other point context is common for all devices: - dif_storep (array of t10 dif tuples) - map_storep (block map for thinprovision) - fake_storep (in memory data storage) - sdebug_q_arr (queue array) So basically we may have many devices with single context which refers common data. Are any sane reason to share context between devices? Who use such behaviour? IMHO this is a pure bug. Please correct me if I'm wrong, I'll plan to fix that by allocation separate context for each dev.