Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbdC0SP5 (ORCPT ); Mon, 27 Mar 2017 14:15:57 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:35921 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbdC0SPs (ORCPT ); Mon, 27 Mar 2017 14:15:48 -0400 Subject: Re: [PATCH V7 00/18] blk-throttle: add .low limit To: Shaohua Li , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: Cc: tj@kernel.org, Vivek Goyal , jmoyer@redhat.com, Kernel-team@fb.com From: Jens Axboe Message-ID: Date: Mon, 27 Mar 2017 12:15:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 283 Lines: 9 On 03/27/2017 11:51 AM, Shaohua Li wrote: > V6->V7: > - Don't overload blk stat, which will simplify the code. This will add extra > space in bio/request though with the low interface configure option on. Hmm, why? As far as I can see, it just makes things worse. -- Jens Axboe