Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbdC0TL5 (ORCPT ); Mon, 27 Mar 2017 15:11:57 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:58843 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdC0TLs (ORCPT ); Mon, 27 Mar 2017 15:11:48 -0400 Subject: Re: [PATCH V7 00/18] blk-throttle: add .low limit To: Shaohua Li , Jens Axboe References: <20170327190043.GA96008@dhcp-172-20-189-90.dhcp.thefacebook.com> CC: , , , Vivek Goyal , , From: Jens Axboe Message-ID: <567d5361-7d6b-c53e-8ada-a2966e48dc54@fb.com> Date: Mon, 27 Mar 2017 13:11:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170327190043.GA96008@dhcp-172-20-189-90.dhcp.thefacebook.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BN6PR02CA0029.namprd02.prod.outlook.com (10.173.146.143) To MWHPR15MB1200.namprd15.prod.outlook.com (10.175.2.142) X-MS-Office365-Filtering-Correlation-Id: 47d1a978-1175-48bf-7583-08d475451826 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423049)(201703031133055);SRVR:MWHPR15MB1200; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;3:JpdPtV1ts2QiwBegeBglp4zi7y/Bobqg6CXV/zUXGpUZ57S+0el8S2GTuNNH0LNnxKW7yEI+lodToWHsz7szaXcl30aQK5FIrEOzgc+cs3h+p9FwOJxAlWPw1Z0bsh2kXJcOd8Z/oy4KeOqf3NuS1cu6g4Onxm9d9x+EifwM3Nlj8GGzNmbQArfo0g8WdvPzhQwMbUfCol/MUz4PxzA7B5kog2e1kCEbs7oatlFnnyU6UGx9v+F6hdtTtyKgBWkJKkjB3jqVrTCxrSjeugMcBNAss5J7QoxAACrSvh0YFufnWlHzhzTZvrkTI1plAN+tFJUZFdJNPs7rEjlMi8GF3w==;25:3EmVG6OVfkL+eAGyc0IjdwY3nw+pBIIVQFfmqD2IRA4mPgfa2+ryoaElZbNEp8zY04SbUt81AC5eL9ahjppoHphYvCEKFZAW+6zB0gnfVbxaLaRRu0pL8ksNJhJ5+3R+vrotnV3N7+Rv8paiHMv/+lNIYtkijgbAv15sEtczAim3od4qGTg1Ft81epMDKYU0RAUxixVWoo3RMtrFl6rn2YZrxT5PPilv5rKQbIqvkXdKfAT5AJyPLWDSi3rkFTfkXrBjzmzB3XlBPGSunCeyW4VO4jKDnMn/rMfhGPF/Jh0RpafMQO0GuC9zZx7aWUXbnmBGah2IzsR8MiB+BsTM3ghkQ5RNfIjy0PkD3B8bAE4S85z5bqvQa8GWMLSUJuH8ufnioh7GWv4hXUH2LASJXiAsu584IabDOWuBtZh3o6cf/QR03vCa1C6UHjQAHIfWXJemFlygNbBL2ITpa/F2Pg== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;31:S4Psb9R5/kKFc9U8FOykzZoJUGskUEE/24msfIYX8LL1dVDozhjy3kK/Wj36Nh75I71oQpQ6UvVKDAFmzQWsdx6eWlQ8qobuy6dvNPggp2gSmCi3wNTLN8B7cVo4980k9UiQu1AJhQdH8uvKMoRppG1Zc8HuVZWUujzAGIco+h4EceBHAOKVGkTKJ+OBz8DfOJvGQzjf11bH/6EC/L7eWEG3bNu0fraIiQvLAW4cj2c=;20:Qus5A2FCxbBSQOSJI9DRzXF7NZYO13s3r8yP9/ygccntfYDX6RhRA5MurN275FFjcolO8ObUaiZ3cOf1XUrab8q6uLQWUXuJIbkI8wckFkf+8RRakBBE0I3zU+t4Iecx5LCP5aJKohYn61v90Q/Rmd+AyHVxSj0eEHU4dtsRtkyIW/tYN/6MClPRQht3tHgyNNYrlOXrEgUIMicpeGwfmO4X1i9ECBxDqmanhr4lo2nBkMRhnYS9LxSe8cfK537+EgbkxHTvKt16hCa7LFsHssX/wDz0Q4gMA+vqAPM4ewks4mmzSjnNPZJoW20s0dFzonsaZa2dnyPZQSrNJbHaFksygIQeXvm4wX/KLw91uKBLgcYe6pp1AJGQ6fs3Fc1jxyb4KVnhkKhv1GX72YJfbk3f26h/EPMo1IYQWijyCTtp1qJ8WXWO2Umi7GoAB6h7t9zuFlspcSfa2+cAEbwZJIzPB0zTSmi030njZgTsXzihs3QHDVVjVXDQuwuPPuL1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040423)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(201703131423048)(201702281528048)(201703061421048)(201703061406048)(20161123564025)(20161123562025)(20161123558025)(6072148);SRVR:MWHPR15MB1200;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1200; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;4:mgJcq4GtRd3eUsvqL1VDTp7UhSNNJMKS2TFQ4qtBEbpcUjrXbP4EOBJ6vr58AcPXcZYcX1AtNtOd/36ru+mENg0DpUEnzll27rOGSDntKtPydjMHo+vt3qK+1WT4TYXThSze7JYWh4E1Gih8j7ljGID/2T1CC2aBQL+xB7dCSZ9NKoyPJzXuCaerA18fxiBjsI3qAYlyQcXLTOwxFcxXd6pMgLpNdw6yLSkVVjhsF/g0Fm4GFOgLdxYzSmT+D+NX1fOKl1t7ivr3F4q/1rjLUfBfjFnVt530VH4lVNDRuncj2+4Tc5qjdhWsGnozhjeH2UOM96goEbAnMkDrtczqXFesozK49PYrgKioWtR/drak1r8BNw2MV1egituZf9BRGaOOAZsAR2yjijTQ40BfJiHF6Tz43RpihtoEMB10D0MbzCM4oZKHZoR3LGOx9FeOlXw8Za4ch6M8CRdcV+ZtI28BcG4zdKlAEERMut3LiB/Qixzugj89Us5c0SYBxVZxv5jaPm8924jim+p2ay1Y2J63tzXN3Jr70xq4MP3Ei25x1Jr1ZWsg6oyvHs9Bw1Cd6XWHCrFkLIsJn/rMrZdgiYIhsbVmDI+DnVVYmOh6G+Sn967ZNySWCqsmNbxe2wzaBfFYLvzT1mhavcML/UbRyazEwE4qYOwoeEwQHNgQwEx70zc0gjoumxWE58oYYWpUE6XiX9IL5ytZ1agsJQ3SSiK+v3wTiyhr8GqP/pM/Mu4jFRAi0wBHIZ09zn+Dh/OY X-Forefront-PRVS: 02596AB7DA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39850400002)(39410400002)(39400400002)(39840400002)(39450400003)(377454003)(24454002)(64126003)(65956001)(66066001)(50466002)(65806001)(76176999)(23746002)(230700001)(54356999)(81166006)(50986999)(47776003)(31696002)(86362001)(3846002)(6116002)(36756003)(54906002)(7736002)(305945005)(5660300001)(53936002)(117156002)(77096006)(90366009)(6486002)(6666003)(25786009)(2950100002)(53546009)(6246003)(229853002)(38730400002)(4326008)(189998001)(4001350100001)(42186005)(2906002)(33646002)(8676002)(31686004)(83506001)(142923001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1200;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1200;23:P/pFGr/Y23RN/jkNOLvBTHUfWOUPC8Pshn/i7?= =?Windows-1252?Q?gYH4cejdYOkdNOoFmv5D8OoMa2coQvmg4lbFBu5LGwsXAW1x5G6pTEZN?= =?Windows-1252?Q?RMiaH7NakPVKz6AlJHtog3b7jSaRx02D81ICjm871EKBt1/+U2YafZIC?= =?Windows-1252?Q?FgMIHBw8nu7eUw72KUJzWqOw96k34taRZbhXj0/XkTU8T6vXoErYclK1?= =?Windows-1252?Q?q03jneXu6wJ171ltAQZdEc1QXCNiW11qpA1SQwzS1JlWR7iu4jkU57+X?= =?Windows-1252?Q?bkXh7rA/CJZOtRJIDsQLybcp5g6594ApDAGv2+K/rAAQYmPZUHTZn4MC?= =?Windows-1252?Q?bqqTnw4yMzASthwWHeXd6Ztmv21PEJ8b//etv35WRLmN0GwN5AX1fYLI?= =?Windows-1252?Q?6N6Z4kn0Pp8pneBs256LHcTchoniTDZojArBboEXoqBB93o0hOdwqRuX?= =?Windows-1252?Q?frbz3aqxxvZtXPshclFfHmP8Bp/iCgiDX+jgK8yhmCItXwWycm66fMjm?= =?Windows-1252?Q?q9SCwMzvvY896qwRwnlyUPS3Rmn40vsG7r5FugsmEy/iYHvNFDE1ebgb?= =?Windows-1252?Q?ED1PF7lCsgUeo9FYHI/ChoSa9O62qESLDOLcMM0NsTYopmXR+FOZdEiF?= =?Windows-1252?Q?RpF4kicNhKIJ6h1iXEvv9cgBxU5JYZVWzb8DouAsJhnxJ0EO/qrd8rD/?= =?Windows-1252?Q?uh8eRMcs/wAbxpzOM3SO1QIpygfI2CQR2afEZ15w5R9oVABIBT/PHzYs?= =?Windows-1252?Q?yhRVO1kjhXG93JMERM3+lvjb/BZAffsuGASVEI7+vi/bBEn5NTeFKJnw?= =?Windows-1252?Q?Mw4gUtDDSzrk4W8piNBVfRcnwv2BV5zFw5SG4XrijX9Kp5rf1F46RCzG?= =?Windows-1252?Q?PCx8HCYQThvNKWYP2D7s1tkJW0rWx447K9dk96dsYK17xEyLrCi7fd38?= =?Windows-1252?Q?goekBRWMvOi8sH4b4m0oW7xYJ1dGRy8kLrRTOcymNFuYMq+TC5M3skaL?= =?Windows-1252?Q?IRF9Xm00jDCnSIW4A7ZwzduJ5fLhzQ6QsGnW1eiEsqeURh89Px3Nx6G4?= =?Windows-1252?Q?NYdFzLdWOZs1C8ubLKdngFZw1T6OyKsoS/0PIbF/m8JHCpLMlBkaVizs?= =?Windows-1252?Q?/JTEZkkZdgpIRVlrhd+f0dJrDf0wUHzZE8n1sLgaKkkKN7T8FufkCPSd?= =?Windows-1252?Q?LRhGymOHgsDXU7VnTo7VxsXAm89OvUE9keBA0HpmxrSLQQSIbH0u707N?= =?Windows-1252?Q?WIYGktl+Rx+qyUL4mWWspzw1gaQqCBqVTDKI5RcZcA6kh8FauCMc7IHL?= =?Windows-1252?Q?OO+6XksKe6njN9GdnCLyp3pc2lKd7171XZIf4PeupPG1TqJyypmjD0NZ?= =?Windows-1252?Q?I73mQxnJaDFKnITxnt6LeEq7c1OCMUak2C1MfwKmxZdldMzGcJVEoY?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;6:/LfLe4Qk4pzU62N/zr6/0MG99Im2ZxUv1qCoD9LB4jcYE8xlMCDPdZUdXpIuJVNUkkcWRqFoGuLeY5XnSWDk3LJA00kEM/IcgmKTMMxDDeKU3bKI3OUqViC0/PdBXiOJ9ZuHy9zYPG68k/2G8xl3DoVPemEW85/SmFTCS4I6SHDU0GOg5vlc1sE8wkhYM/hy6vpiRgNmwzO7dUEuCwSZy6yTKbeBdYawJSFGsk+R0LwvawrsC8fyIIcHClFiGgaVZyr70fOjZAmYfcACWusslXqPTUBbCAXFD3rZXt+QHgtAfcNV6q8JSqfpkrZ2kw++elwqPscoV/c8vTpcgaLx+GvGFtzqv0y9JZ38T4ytlqTais9oXeqz9q62yULnxnNYj1/ymab/fh108hF3P7eViw==;5:lH0N4KKcPJoLbj9iPVaqwhwsuBR8Q8/ABAqDONYVk25rqbu+JPWQ4VIk6YUYZcUuahzzOmJwsKl1MCzT1bMjKmeUYPV99CTw6oQcrHrAToTWJorYOIzqCZ8szRdBkcso4pHEecMrJgKQKuILZkOhyA==;24:myV0Nldpp0vCKWlA3sX66FHo/J87KnuMfvDs97gD/S5aYS9pfZlpJFEm6FvYogb+gsMWy5vX7d54LIw0wroaxmc7C/jI90pRbWu9r4dTwmA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1200;7:4JZsyxtGSY4rr/PUJE97pX4ILPQbcfpCDs4iUwJuk4m3mquIYtqVvJfONAiMIsO6WK+UgDXsMlKg9rUar8v/qPknU3XtN5ilU8a62AAqDtVBDdq5IcG95JiOQv29wKNGrp1U/cA2HJ3M42swMZnBfhEYertNZYl/g/PeFjTUFG3qyE+T3lb13dsX93Pqg7SuLdvj9/Ff07Qmdc0M9+ERL3KnNHFclGz5/XXLhTc5ZvptXSrqKRAESvwV97sCUBXils5fkstp+rU5bFUPSLVq83KCGIG9vGqHGHvNAQA2ZX7oHj60/sVebtFD0LfS+C5QvTyU9ivl8uQNUuRKS3mpjw==;20:Dl0UAz8l/gXtY3SdhpGRPS2fTDQxZiokLK10t0J7N7QIVp0MYAx60CCQJEt1/1v9u/ebgelbB4aXYgS2e1q7hyejeYKJxC04abwEDyLIl91BioFMkbQxnpKHulZs92LGQs4sTmvAn9/2Pkp/ntu3ZVgshIbAJ2q4NkCQ6X9bizc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2017 19:11:36.7495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1200 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-27_17:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 18 On 03/27/2017 01:00 PM, Shaohua Li wrote: > On Mon, Mar 27, 2017 at 12:15:29PM -0600, Jens Axboe wrote: >> On 03/27/2017 11:51 AM, Shaohua Li wrote: >>> V6->V7: >>> - Don't overload blk stat, which will simplify the code. This will add extra >>> space in bio/request though with the low interface configure option on. >> >> Hmm, why? As far as I can see, it just makes things worse. > > Part of the reason is the new callback based blk stat makes enabling stat less > straightforward. I probably can create a fake callback and enalbing the stat > though. Only the last 3 patches depend on this, if you prefer, I can resend > them and add the overload back. Yeah, I think that would be a big improvement. -- Jens Axboe