Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbdC0UDM (ORCPT ); Mon, 27 Mar 2017 16:03:12 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:34150 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbdC0UDE (ORCPT ); Mon, 27 Mar 2017 16:03:04 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: Neil Armstrong , sboyd@codeaurora.org, carlo@caione.org, khilman@baylibre.com From: Michael Turquette In-Reply-To: <1490178747-14837-1-git-send-email-narmstrong@baylibre.com> Cc: "Neil Armstrong" , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <1490178747-14837-1-git-send-email-narmstrong@baylibre.com> Message-ID: <149064493648.54062.5595306508519104671@resonance> User-Agent: alot/0.3.7 Subject: Re: [PATCH v2 0/5] clk: meson: Fix GXBB and GXL/GXM GP0 PLL Date: Mon, 27 Mar 2017 13:02:16 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2RK3t76019700 Content-Length: 2004 Lines: 50 Hi Neil, Quoting Neil Armstrong (2017-03-22 03:32:22) > This patchset fixes support for the Amlogic GXBB then GXL/GXM embedded GP0 PLL. > > The current support is done via a very generic interface where only the > N/M/OD parameters are changed in the control registers. > > But unlike the Fixed PLL, this PLL is not initialized by the bootloader or > firmware, and needs some parameters to initialize and lock correctly. > > This patchset also adds the GXL variant compatible string which is already > supported by the GXL and GXM DT nodes. > > Changes since v1 at [1]: > - Rebase on the Mali clocks patchset at [2] > - also depends on v2 Audio Clocks patchset from Jerome Brunet at [3] > - Add match table and separate tables for gxl > - Switch to probe function to use match table data only > - Rename unreset_for_lock to clear_reset_for_lock Thanks for the quick changes. Applied to clk-meson, a stable branch, which was merged into clk-next. Best regards, Mike > > [1] http://lkml.kernel.org/r/1489411604-18700-1-git-send-email-narmstrong@baylibre.com > [2] http://lkml.kernel.org/r/1490177935-9646-1-git-send-email-narmstrong@baylibre.com > [3] http://lkml.kernel.org/r/20170309104154.28295-1-jbrunet@baylibre.com > > Neil Armstrong (5): > clk: meson: Add support for parameters for specific PLLs > clk: meson-gxbb: Add GP0 PLL init parameters > clk: meson-gxbb: Add GXL/GXM GP0 Variant > clk: meson-gxbb: Expose GP0 dt-bindings clock id > dt-bindings: clock: gxbb-clkc: Add GXL compatible variant > > .../bindings/clock/amlogic,gxbb-clkc.txt | 3 +- > drivers/clk/meson/clk-pll.c | 53 +++- > drivers/clk/meson/clkc.h | 23 ++ > drivers/clk/meson/gxbb.c | 314 +++++++++++++++++++-- > drivers/clk/meson/gxbb.h | 4 +- > include/dt-bindings/clock/gxbb-clkc.h | 1 + > 6 files changed, 366 insertions(+), 32 deletions(-) > > -- > 1.9.1 >