Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753667AbdC1BBj (ORCPT ); Mon, 27 Mar 2017 21:01:39 -0400 Received: from mout.gmx.net ([212.227.15.18]:49549 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287AbdC1BBi (ORCPT ); Mon, 27 Mar 2017 21:01:38 -0400 Message-ID: <1490662886.27756.1.camel@gmx.de> Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") From: Mike Galbraith To: Christoph Hellwig Cc: Thorsten Leemhuis , mst@redhat.com, virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Date: Tue, 28 Mar 2017 03:01:26 +0200 In-Reply-To: <20170327170540.GA28715@lst.de> References: <20170323145622.GA31690@lst.de> <1490605644.14634.50.camel@gmx.de> <20170327170540.GA28715@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:18sFgC/kATVqNg+81kS9x7X5t/ZvmMMPBlMrCaHlaa1C64Fq9gu Uaqx0URdrKoIbUfHKIPkO/+ogARDTx17AvDtYrKlPCBDzZ+b7sZ+gy1WoAB9SHDjmFT71zv B8E7ULjpuMjcrbYsV+ZlNRY5nG6d+ZHC+BQLkS6P/89B48UNcONWjD9WNx/euy+vu+YEgKh RfTy+dat9AGyzOSZuRS6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:OXpmSGSGa1k=:iEfGWaHPXxfy27kio+F5A4 fMEyLdZBxbXhDSSh1qNsObxFPtzqC40kYRekcqFSutM7fer5ylhwgdF4xdgKCYDwGn3+XdPF1 piZ1taqeN5SAEFAhQgjILRJkS2eKP2jHXs7D5jElG2TkkPmgeDRXtcq4BReXedTS9PO7SF4fK iMf1nJbIjHAMm7vOdt9uh1blWz5Wh0Doe2pVJwlzivGXSbUIJy+/2PqINv4UR+r8V94NvcJ86 hB5/B3rOygQksmKX6KvtvK5ShWi9OXz3OM2+jGLodQxuqEipIJaZzqggM4zxutDYF4ZEIz/xU ZPt+ZSQ+3arjLL3JJdmFI+rd/H92B8uWbrL3yCu/m6ytwpb3fy8hvvYpP2h9k2vKpEo3OGpRv xJlrMy/wjPs8RLWgheLS6D1cYtLv5tWU+tWQgf+nQ4tkpCExHJsKgEvE6iwbNkkK4HGY/XpZ/ 9426uYSRqZD3qvaoRDuscS26kBNtCY01s37UY8VBX0D1b0aG5Y3HsU0YiEauZytNFO3uHgDTj zMr5EEJ6/nbyKuKgqtxEoI0lQvfhs1iwA1oAlXL6D3QGFlBJMTjH6LOGCZnEkj1egMPGoPME5 pIwBYx/ilz1iAxSZ8tFierYDb7G52pkiGdovJkzAjLCaZIgruR3zAuND5Gkw7U/GtdeKSclX6 /xxM7Xdg2l8qWchRTJrYGVIT9idl/q35Nhpz79bZ7UQtJfhSGVRM9P0zB1EEPcmV7K1UsZgxH c87mDLS3u4YruxtjZBsG42TzhTNXYfbBu4kbUcFjzIeDQhoCumj9VxZI+6VmyxEdOAuOzoU/L QUGVTMv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 23 On Mon, 2017-03-27 at 19:05 +0200, Christoph Hellwig wrote: > Hi Mike, > > does the patch below fix that issue for you? Nope, warnings are alive and well. > diff --git a/drivers/virtio/virtio_pci_common.c > b/drivers/virtio/virtio_pci_common.c > index df548a6fb844..fd1b06368b1f 100644 > --- a/drivers/virtio/virtio_pci_common.c > +++ b/drivers/virtio/virtio_pci_common.c > @@ -176,7 +176,7 @@ static int vp_find_vqs_msix(struct virtio_device > *vdev, unsigned nvqs, > if (err < 0) > return err; > > - vp_dev->msix_vectors = nvectors; > + vp_dev->msix_vectors = err; /* number of vectors allocated > */ > vp_dev->msix_names = kmalloc_array(nvectors, > sizeof(*vp_dev->msix_names), GFP_KERNEL); > if (!vp_dev->msix_names)