Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbdC1BzL (ORCPT ); Mon, 27 Mar 2017 21:55:11 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28888 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbdC1BzK (ORCPT ); Mon, 27 Mar 2017 21:55:10 -0400 To: Dan Carpenter Cc: Boaz Harrosh , Benny Halevy , "James E.J. Bottomley" , "Martin K. Petersen" , osd-dev@open-osd.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: osd_uld: remove an unneeded NULL check From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170323104142.GD20154@mwanda> Date: Mon, 27 Mar 2017 21:54:48 -0400 In-Reply-To: <20170323104142.GD20154@mwanda> (Dan Carpenter's message of "Thu, 23 Mar 2017 13:41:42 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 318 Lines: 10 Dan Carpenter writes: > We don't call the remove() function unless probe() succeeds so "oud" > can't be NULL here. Plus, if it were NULL, we dereference it on the > next line so it would crash anyway. Applied to 4.12/scsi-queue (by hand). -- Martin K. Petersen Oracle Linux Engineering