Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753893AbdC1CYa (ORCPT ); Mon, 27 Mar 2017 22:24:30 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58032 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753795AbdC1CY1 (ORCPT ); Mon, 27 Mar 2017 22:24:27 -0400 Date: Mon, 27 Mar 2017 19:23:54 -0700 From: Darren Hart To: Michael Ellerman Cc: Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, bamvor.zhangjian@huawei.com, Shuah Khan , stable@vger.kernel.org Subject: Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable Message-ID: <20170328022354.GA590@localhost.localdomain> References: <20170324161854.GA6958@fury> <87efxi8d82.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87efxi8d82.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 42 On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote: > Darren Hart writes: > > > The use of $$OUTPUT in the target shell commands resulted in an empty > > string followed by an absolute path for which mkdir failed: > > > > $ make -C tools/testing/selftests/futex > > make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex' > > Makefile:36: warning: overriding recipe for target 'clean' > > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > for DIR in functional; do \ > > BUILD_TARGET=$OUTPUT/$DIR; \ > > mkdir $BUILD_TARGET -p; \ > > make OUTPUT=$BUILD_TARGET -C $DIR all;\ > > done > > mkdir: cannot create directory ‘/functional’: Permission denied > > > > Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT > > variable. The above make command now completes successfully. > > > > Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") > > Signed-off-by: Darren Hart (VMware) > > Cc: linux-kselftest@vger.kernel.org > > Cc: bamvor.zhangjian@huawei.com > > Cc: Shuah Khan > > Cc: # 4.10.x- > > The OUTPUT support only went into v4.11-rc1, so I don't see why you need > a stable tag? Git spelunking failure on my part, you are correct. Please disregard the stable tag. > > Change looks good though. > Thank you for the review. -- Darren Hart VMware Open Source Technology Center