Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754018AbdC1EWH (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Mar 2017 00:22:07 -0400
Received: from szxga03-in.huawei.com ([45.249.212.189]:4465 "EHLO
        dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751316AbdC1EVy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Mar 2017 00:21:54 -0400
Subject: Re: [PATCH V13 10/10] arm/arm64: KVM: add guest SEA support
To: Christoffer Dall <cdall@linaro.org>,
        Tyler Baicar <tbaicar@codeaurora.org>
References: <1490136425-4324-1-git-send-email-tbaicar@codeaurora.org>
 <1490136425-4324-11-git-send-email-tbaicar@codeaurora.org>
 <20170324160158.GH25903@cbox>
CC: <christoffer.dall@linaro.org>, <marc.zyngier@arm.com>,
        <pbonzini@redhat.com>, <rkrcmar@redhat.com>, <linux@armlinux.org.uk>,
        <catalin.marinas@arm.com>, <will.deacon@arm.com>, <rjw@rjwysocki.net>,
        <lenb@kernel.org>, <matt@codeblueprint.co.uk>,
        <robert.moore@intel.com>, <lv.zheng@intel.com>, <nkaje@codeaurora.org>,
        <zjzhang@codeaurora.org>, <mark.rutland@arm.com>,
        <james.morse@arm.com>, <akpm@linux-foundation.org>,
        <eun.taik.lee@samsung.com>, <sandeepa.s.prabhu@gmail.com>,
        <labbott@redhat.com>, <shijie.huang@arm.com>,
        <rruigrok@codeaurora.org>, <paul.gortmaker@windriver.com>,
        <tn@semihalf.com>, <fu.wei@linaro.org>, <rostedt@goodmis.org>,
        <bristot@redhat.com>, <linux-arm-kernel@lists.infradead.org>,
        <kvmarm@lists.cs.columbia.edu>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
        <linux-efi@vger.kernel.org>, <devel@acpica.org>,
        <Suzuki.Poulose@arm.com>, <punit.agrawal@arm.com>, <astone@redhat.com>,
        <harba@codeaurora.org>, <hanjun.guo@linaro.org>,
        <john.garry@huawei.com>, <shiju.jose@huawei.com>, <joe@perches.com>
From: gengdongjiu <gengdongjiu@huawei.com>
Message-ID: <734ab018-2112-eddf-10dc-426f8ebe3848@huawei.com>
Date: Tue, 28 Mar 2017 12:19:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20170324160158.GH25903@cbox>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.68.147]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A0B0207.58D9E47C.0074,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 5faa8d9472e5b747a16b0dcbc2b15314
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 542
Lines: 14

Hi Tyler,

I have a question for below code.

On 2017/3/25 0:01, Christoffer Dall wrote:
>  	is_iabt = kvm_vcpu_trap_is_iabt(vcpu);
> -	if (unlikely(!is_iabt && kvm_vcpu_dabt_isextabt(vcpu))) {
> +	if (unlikely(!is_iabt && kvm_vcpu_dabt_isextabt(vcpu)) && sea_status) {
>  		kvm_inject_vabt(vcpu);
when it is SEA synchronized abort, why here inject a asynchronous abort through kvm_inject_vabt(vcpu) instead of synchronized abort? seem the original kvm source code is also do that, so I am confused about that.
thanks .

>  		return 1;
>  	}