Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754191AbdC1Ffz (ORCPT ); Tue, 28 Mar 2017 01:35:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60271 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754059AbdC1Ffx (ORCPT ); Tue, 28 Mar 2017 01:35:53 -0400 Date: Tue, 28 Mar 2017 07:35:39 +0200 From: Heiko Carstens To: Kees Cook Cc: Andrew Morton , Martin Schwidefsky , Arnd Bergmann , Catalin Marinas , Chris Metcalf , Jakub Kicinski , linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Eddie Kovsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix section name for .data..ro_after_init References: <20170327192213.GA129375@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327192213.GA129375@beast> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17032805-0016-0000-0000-00000466EB30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032805-0017-0000-0000-000026FD6C3E Message-Id: <20170328053539.GA4902@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-28_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280052 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 28 On Mon, Mar 27, 2017 at 12:22:13PM -0700, Kees Cook wrote: > A section name for .data..ro_after_init was added by both: > > commit d07a980c1b8d ("s390: add proper __ro_after_init support") > > and > > commit d7c19b066dcf ("mm: kmemleak: scan .data.ro_after_init") > > The latter adds incorrect wrapping around the existing s390 section, > and came later. I'd prefer the s390 naming, so this moves the > s390-specific name up to the asm-generic/sections.h and renames the > section as used by kmemleak (and in the future, kernel/extable.c). > > Cc: Jakub Kicinski > Cc: Heiko Carstens > Cc: Eddie Kovsky > Signed-off-by: Kees Cook > --- > arch/s390/include/asm/sections.h | 1 - > arch/s390/kernel/vmlinux.lds.S | 2 -- > include/asm-generic/sections.h | 6 +++--- > include/asm-generic/vmlinux.lds.h | 4 ++-- > mm/kmemleak.c | 2 +- > 5 files changed, 6 insertions(+), 9 deletions(-) For the s390 bits: Acked-by: Heiko Carstens