Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754526AbdC1GBR (ORCPT ); Tue, 28 Mar 2017 02:01:17 -0400 Received: from terminus.zytor.com ([65.50.211.136]:38767 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752760AbdC1GBP (ORCPT ); Tue, 28 Mar 2017 02:01:15 -0400 Date: Mon, 27 Mar 2017 22:57:29 -0700 From: tip-bot for Tommi Rantala Message-ID: Cc: mingo@kernel.org, acme@redhat.com, alexander.shishkin@linux.intel.com, tommi.t.rantala@nokia.com, peterz@infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com Reply-To: mingo@kernel.org, alexander.shishkin@linux.intel.com, acme@redhat.com, peterz@infradead.org, tommi.t.rantala@nokia.com, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de In-Reply-To: <20170322130624.21881-4-tommi.t.rantala@nokia.com> References: <20170322130624.21881-4-tommi.t.rantala@nokia.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tests: Do not assume that readlink() returns a null terminated string Git-Commit-ID: 0e6ba11511aef91ba8e2528ddc681d88922d7b0b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 33 Commit-ID: 0e6ba11511aef91ba8e2528ddc681d88922d7b0b Gitweb: http://git.kernel.org/tip/0e6ba11511aef91ba8e2528ddc681d88922d7b0b Author: Tommi Rantala AuthorDate: Wed, 22 Mar 2017 15:06:21 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 27 Mar 2017 15:35:56 -0300 perf tests: Do not assume that readlink() returns a null terminated string Ensure that the string in buf is null terminated. Signed-off-by: Tommi Rantala Cc: Alexander Shishkin Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20170322130624.21881-4-tommi.t.rantala@nokia.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/sdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/sdt.c b/tools/perf/tests/sdt.c index f59d210..26e5b7a 100644 --- a/tools/perf/tests/sdt.c +++ b/tools/perf/tests/sdt.c @@ -43,7 +43,7 @@ static char *get_self_path(void) { char *buf = calloc(PATH_MAX, sizeof(char)); - if (buf && readlink("/proc/self/exe", buf, PATH_MAX) < 0) { + if (buf && readlink("/proc/self/exe", buf, PATH_MAX - 1) < 0) { pr_debug("Failed to get correct path of perf\n"); free(buf); return NULL;