Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754469AbdC1GGQ (ORCPT ); Tue, 28 Mar 2017 02:06:16 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36779 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbdC1GGO (ORCPT ); Tue, 28 Mar 2017 02:06:14 -0400 Date: Tue, 28 Mar 2017 08:06:04 +0200 From: Ingo Molnar To: "Kirill A. Shutemov" Cc: Linus Torvalds , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andi Kleen , Dave Hansen , Andy Lutomirski , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] x86/boot: Detect 5-level paging support Message-ID: <20170328060604.GA20135@gmail.com> References: <20170327162925.16092-1-kirill.shutemov@linux.intel.com> <20170327162925.16092-2-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327162925.16092-2-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 359 Lines: 20 * Kirill A. Shutemov wrote: > +#ifdef CONFIG_X86_5LEVEL > +#define DISABLE_LA57 0 > +#else > +#define DISABLE_LA57 (1<<(X86_FEATURE_LA57 & 31)) > +#endif > +#ifdef CONFIG_X86_5LEVEL > +# define NEED_LA57 (1<<(X86_FEATURE_LA57 & 31)) > +#else > +# define NEED_LA57 0 > +#endif Please use consistent style. Thanks, Ingo