Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754559AbdC1Gy7 (ORCPT ); Tue, 28 Mar 2017 02:54:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60762 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754450AbdC1Gy5 (ORCPT ); Tue, 28 Mar 2017 02:54:57 -0400 Subject: Re: [PATCH v2 1/3] perf/sdt/x86: Add renaming logic for (missing) 8 bit registers To: Masami Hiramatsu References: <20170327075829.2205-1-ravi.bangoria@linux.vnet.ibm.com> <20170327075829.2205-2-ravi.bangoria@linux.vnet.ibm.com> <20170327231715.cf9a6e2571347157d6266d98@kernel.org> Cc: acme@redhat.com, alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au, hemant@linux.vnet.ibm.com, Ravi Bangoria From: Ravi Bangoria Date: Tue, 28 Mar 2017 12:24:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170327231715.cf9a6e2571347157d6266d98@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17032806-0004-0000-0000-000011DAE509 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006863; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000206; SDB=6.00839808; UDB=6.00413221; IPR=6.00617711; BA=6.00005242; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014831; XFM=3.00000013; UTC=2017-03-28 06:54:54 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17032806-0005-0000-0000-00007E27E61A Message-Id: <58DA08B4.9000503@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-28_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280066 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 32 Hi Masami, Thanks for the review. On Monday 27 March 2017 07:47 PM, Masami Hiramatsu wrote: > On Mon, 27 Mar 2017 13:28:27 +0530 > Ravi Bangoria wrote: > >> I found couple of events using al, bl, cl and dl registers for >> argument. These are not directly accepted by uprobe_events and >> thus needs to be mapped to ax, bx, cx and dx respectively. >> >> Few ex, >> >> /usr/bin/qemu-system-s390x >> css_adapter_interrupt: 1@%bl >> css_chpid_add: 1@%cl 1@%sil 1@%dl >> dma_bdrv_io: 8@%rbx 8@%rbp -8@%r14 1@%al >> >> /usr/bin/postgres >> buffer__read__done: ... -1@-bash -1@%al >> buffer__read__start: ... -1@%al > Of course, it should be suppoted. BTW, wouldn't we take care about ah, bh ... too? I thought about them while preparing this patch, but I couldn't find any events using those registers. So I ignored them. But I think no one stops compiler to use those registers for sdt argument. And if so, they should get included. Will send v3 for this. Thanks, Ravi