Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754785AbdC1I3K (ORCPT ); Tue, 28 Mar 2017 04:29:10 -0400 Received: from mail-pg0-f44.google.com ([74.125.83.44]:33184 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678AbdC1I3J (ORCPT ); Tue, 28 Mar 2017 04:29:09 -0400 Date: Tue, 28 Mar 2017 01:20:16 -0700 From: Jakub Kicinski To: Kees Cook Cc: Andrew Morton , Martin Schwidefsky , Heiko Carstens , Arnd Bergmann , Catalin Marinas , Chris Metcalf , linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Eddie Kovsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: fix section name for .data..ro_after_init Message-ID: <20170328011951.33dc329c@cakuba.lan> In-Reply-To: <20170327192213.GA129375@beast> References: <20170327192213.GA129375@beast> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 20 On Mon, 27 Mar 2017 12:22:13 -0700, Kees Cook wrote: > A section name for .data..ro_after_init was added by both: > > commit d07a980c1b8d ("s390: add proper __ro_after_init support") > > and > > commit d7c19b066dcf ("mm: kmemleak: scan .data.ro_after_init") > > The latter adds incorrect wrapping around the existing s390 section, > and came later. I'd prefer the s390 naming, so this moves the > s390-specific name up to the asm-generic/sections.h and renames the > section as used by kmemleak (and in the future, kernel/extable.c). > > Cc: Jakub Kicinski > Cc: Heiko Carstens > Cc: Eddie Kovsky > Signed-off-by: Kees Cook Acked-by: Jakub Kicinski