Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089AbdC1JQy (ORCPT ); Tue, 28 Mar 2017 05:16:54 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:36037 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754885AbdC1JQv (ORCPT ); Tue, 28 Mar 2017 05:16:51 -0400 MIME-Version: 1.0 In-Reply-To: <20170323105931.10455-2-john@metanate.com> References: <20170323105931.10455-1-john@metanate.com> <20170323105931.10455-2-john@metanate.com> From: Linus Walleij Date: Tue, 28 Mar 2017 11:16:49 +0200 Message-ID: Subject: Re: [PATCH v4 1/4] pinctrl: rockchip: remove unnecessary locking To: John Keeping Cc: Heiko Stuebner , Julia Cartwright , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 531 Lines: 19 On Thu, Mar 23, 2017 at 11:59 AM, John Keeping wrote: > regmap_update_bits does its own locking and everything else accessed > here is a local variable so there is no need to lock around it. > > Signed-off-by: John Keeping > Reviewed-by: Heiko Stuebner > Tested-by: Heiko Stuebner > --- > v3: unchanged > v2.1: > - Remove RK2928 locking in rockchip_set_pull() > v2: > - Also remove locking in rockchip_set_schmitt() Patch applied. Yours, Linus Walleij