Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755090AbdC1JWG (ORCPT ); Tue, 28 Mar 2017 05:22:06 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:58352 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754078AbdC1JWF (ORCPT ); Tue, 28 Mar 2017 05:22:05 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Tue, 28 Mar 2017 10:21:03 +0100 From: Charles Keepax To: Daniel Baluta CC: , , , , , , , , , Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Message-ID: <20170328092103.GQ6986@localhost.localdomain> References: <1490691532-2086-1-git-send-email-daniel.baluta@nxp.com> <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703280085 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 46 On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > Resource managed devm_clk_get only works with platform's device dev. > I feel like this could use an explaination of why not using devm is the correct fix, rather than just using the platform device for the call. Its not obvious to me, that using the platform device would be an issue. Thanks, Charles > Reported-by: Nicolin Chen > Signed-off-by: Daniel Baluta > --- > sound/soc/fsl/imx-wm8962.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c > index 3d894d9..52659fa 100644 > --- a/sound/soc/fsl/imx-wm8962.c > +++ b/sound/soc/fsl/imx-wm8962.c > @@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) > goto fail; > } > > - codec_clk = devm_clk_get(&codec_dev->dev, NULL); > + codec_clk = clk_get(&codec_dev->dev, NULL); > if (IS_ERR(codec_clk)) { > ret = PTR_ERR(codec_clk); > dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret); > @@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) > } > > data->clk_frequency = clk_get_rate(codec_clk); > + clk_put(codec_clk); > > data->dai.name = "HiFi"; > data->dai.stream_name = "HiFi"; > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel