Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932133AbdC1JlX (ORCPT ); Tue, 28 Mar 2017 05:41:23 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:34886 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102AbdC1JlV (ORCPT ); Tue, 28 Mar 2017 05:41:21 -0400 MIME-Version: 1.0 In-Reply-To: <1490286449-19448-6-git-send-email-narmstrong@baylibre.com> References: <1490286449-19448-1-git-send-email-narmstrong@baylibre.com> <1490286449-19448-6-git-send-email-narmstrong@baylibre.com> From: Linus Walleij Date: Tue, 28 Mar 2017 11:30:56 +0200 Message-ID: Subject: Re: [RFT PATCH 5/6] pinctrl: meson: use gpio-ranges from DT To: Neil Armstrong Cc: Kevin Hilman , Carlo Caione , "open list:ARM/Amlogic Meson..." , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 17 On Thu, Mar 23, 2017 at 5:27 PM, Neil Armstrong wrote: '> When trying to add a gpio-hog, we enter a weird loop where the gpio-ranges > is needed when gpiochip_add_data() is called but in the current implementation > the ranges are added from the driver afterwards. > > A simple solution is to rely on the DR gpio-ranges attribute and remove the > call to gpiochip_add_pin_range(). > > Signed-off-by: Neil Armstrong This is fine once the ranges have been applied to the device trees I guess. Tell me when you want me to merge this. Yours, Linus Walleij