Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755432AbdC1KrO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Mar 2017 06:47:14 -0400
Received: from mail-it0-f67.google.com ([209.85.214.67]:34579 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755297AbdC1KrM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Mar 2017 06:47:12 -0400
MIME-Version: 1.0
In-Reply-To: <20170328092103.GQ6986@localhost.localdomain>
References: <1490691532-2086-1-git-send-email-daniel.baluta@nxp.com>
 <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> <20170328092103.GQ6986@localhost.localdomain>
From: Daniel Baluta <daniel.baluta@gmail.com>
Date: Tue, 28 Mar 2017 13:47:04 +0300
Message-ID: <CAEnQRZAx1o9xtbf3u1A_Zun7MSaJjdjunpJm1Q6=ZAA3beoFbA@mail.gmail.com>
Subject: Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
        Nicolin Chen <nicoleotsuka@gmail.com>, Mark Brown <broonie@kernel.org>,
        alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
        Xiubo.Lee@gmail.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Takashi Iwai <tiwai@suse.com>,
        fabio.estevam@nxp.com, linuxppc-dev@lists.ozlabs.org
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1550
Lines: 48

On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote:
>> Resource managed devm_clk_get only works with platform's device dev.
>>
>
> I feel like this could use an explaination of why not using devm
> is the correct fix, rather than just using the platform device
> for the call. Its not obvious to me, that using the platform
> device would be an issue.

Hi Charles,

I see where the confusion comes from :) and I thought the explanation
is obvious from the code, see inline comments.

Would an explanation like the one below, work better?

" We cannot use devm_clk_get with &codec_dev->dev device because
the kernel uses pdev->dev to free the managed resources, so we will end
up with a leaking codec_clk reference"

>> @@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>>               goto fail;
>>       }

pdev->dev from here:

>>
>> -     codec_clk = devm_clk_get(&codec_dev->dev, NULL);
>> +     codec_clk = clk_get(&codec_dev->dev, NULL);

is different from &codec_dev->dev.

>>       if (IS_ERR(codec_clk)) {
>>               ret = PTR_ERR(codec_clk);
>>               dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret);
>> @@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
>>       }
>>
>>       data->clk_frequency = clk_get_rate(codec_clk);
>> +     clk_put(codec_clk);
>>
>>       data->dai.name = "HiFi";
>>       data->dai.stream_name = "HiFi";

thanks,
Daniel.