Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755399AbdC1KvM (ORCPT ); Tue, 28 Mar 2017 06:51:12 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:34187 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754450AbdC1KvI (ORCPT ); Tue, 28 Mar 2017 06:51:08 -0400 MIME-Version: 1.0 In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CD69ECA@SW-EX-MBX02.diasemi.com> References: <539b8756120ab3558c906f7457e65f94dbe37425.1490608293.git.stwiss.opensource@diasemi.com> <201703272258.hWlipe1g%fengguang.wu@intel.com> <20170328082141.u2rgnhei5yhhzxdn@dell> <6ED8E3B22081A4459DAC7699F3695FB7018CD69ECA@SW-EX-MBX02.diasemi.com> From: Geert Uytterhoeven Date: Tue, 28 Mar 2017 12:50:47 +0200 X-Google-Sender-Auth: zFFBwBcaQv50CK4mxnqjmMiSxSA Message-ID: Subject: Re: [PATCH V6 4/7] mfd: da9061: MFD core support To: Steve Twiss Cc: Lee Jones , kbuild test robot , "kbuild-all@01.org" , LINUX-KERNEL , DEVICETREE , Dmitry Torokhov , Eduardo Valentin , Guenter Roeck , LINUX-INPUT , LINUX-PM , LINUX-WATCHDOG , Liam Girdwood , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , Wim Van Sebroeck , Zhang Rui Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2075 Lines: 54 Hi Steve, On Tue, Mar 28, 2017 at 12:42 PM, Steve Twiss wrote: > On 28 March 2017 09:37, Geert Uytterhoeven wrote: >> Subject: Re: [PATCH V6 4/7] mfd: da9061: MFD core support >> On Tue, Mar 28, 2017 at 10:21 AM, Lee Jones wrote: >> >> [auto build test WARNING on ljones-mfd/for-mfd-next] >> >> [also build test WARNING on v4.11-rc4 next-20170327] >> >> base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next >> >> config: x86_64-randconfig-x009-201713 (attached as .config) >> >> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 >> >> reproduce: >> >> # save the attached .config to linux build tree >> >> make ARCH=x86_64 >> >> >> >> All warnings (new ones prefixed by >>): >> >> >> >> drivers//mfd/da9062-core.c: In function 'da9062_i2c_probe': >> >> >> drivers//mfd/da9062-core.c:845:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >> >> chip->chip_type = (int)match->data; >> >> ^ >> > >> > Please use longs or enums. >> >> Enums would still give a warning on 64-bit. >> The simple fix is change the cast from (int) to (uintptr_t). > > Hi Lee and Geert, > > How about this? Fix by redefining the enum chip_type to be an int. > Then, just use substitution: > #define COMPAT_TYPE_DA9061 1 > #define COMPAT_TYPE_DA9062 2 > > That would be simple. > Are there any reasons this would not be acceptable? I don't see how that can help. The warning is caused by casting the "void *" (which is either 32-bit or 64-bit) in of_device_if.data to an integer or enum (which is always 32-bit). The right fix is to cast it to uintptr_t intead of int, like other drivers do. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds