Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755531AbdC1L0G (ORCPT ); Tue, 28 Mar 2017 07:26:06 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33617 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755283AbdC1L0B (ORCPT ); Tue, 28 Mar 2017 07:26:01 -0400 Subject: Re: [PATCH v2] KVM: x86: cleanup the page tracking SRCU instance To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1490694038-27270-1-git-send-email-pbonzini@redhat.com> Cc: gregkh@linuxfoundation.org, dvyukov@google.com, stable@vger.kernel.org From: Xiao Guangrong Message-ID: Date: Tue, 28 Mar 2017 19:25:21 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490694038-27270-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 25 On 28/03/2017 5:40 PM, Paolo Bonzini wrote: > void kvm_page_track_init(struct kvm *kvm) > { > struct kvm_page_track_notifier_head *head; > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 64697fe475c3..f2379673912a 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -8070,6 +8070,7 @@ void kvm_arch_sync_events(struct kvm *kvm) > cancel_delayed_work_sync(&kvm->arch.kvmclock_update_work); > kvm_free_all_assigned_devices(kvm); > kvm_free_pit(kvm); > + kvm_page_track_cleanup(kvm); > } Moving it to kvm_arch_destroy_vm() is better as the init function is called in kvm_arch_init_vm(). Otherwise it looks great to me: Reviewed-by: Xiao Guangrong Thanks for the fix.