Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232AbdC1Ldx (ORCPT ); Tue, 28 Mar 2017 07:33:53 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:33360 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932184AbdC1Ldw (ORCPT ); Tue, 28 Mar 2017 07:33:52 -0400 MIME-Version: 1.0 In-Reply-To: <87bmsm8d2a.fsf@concordia.ellerman.id.au> References: <20170327054601.22415-1-bamvor.zhangjian@linaro.org> <20170327054601.22415-2-bamvor.zhangjian@linaro.org> <87bmsm8d2a.fsf@concordia.ellerman.id.au> From: Bamvor Zhang Jian Date: Tue, 28 Mar 2017 19:33:40 +0800 Message-ID: Subject: Re: [PATCH 1/2] selftests: fix the broken individual test for x86 To: Michael Ellerman Cc: Andy Lutomirski , Shuah Khan , linux-api , lkml , Kevin Hilman , Mark Brown , "Zhang Jian(Bamvor)" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1703 Lines: 43 Hi, Michael On 28 March 2017 at 08:22, Michael Ellerman wrote: > Bamvor Jian Zhang writes: > >> Andy Lutomirski report that build individual testcase in x86 is broken: >> >> $ make -C tools/testing/selftests/x86 ldt_gdt_32 >> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86' >> Makefile:44: warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> make: *** No rule to make target 'ldt_gdt_32'. Stop. >> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86' >> >> This patch fix this issue by adding default OUTPUT and convert >> target in Makefile of x86. >> >> And also mention this use case in Documentation/kselftests.txt >> >> Reported-by: Andy Lutomirski >> Signed-off-by: Bamvor Jian Zhang >> --- >> Documentation/kselftest.txt | 6 ++++++ >> tools/testing/selftests/x86/Makefile | 23 ++++++++++++++--------- >> 2 files changed, 20 insertions(+), 9 deletions(-) > > I don't think this is a good fix, it only fixes this one Makefile, and > it's quite verbose. But if it really bothers Andy then it would be OK as > a stop-gap for 4.11. Thanks for review. Do you mean check this issue in other directory? I plan to do it. Currently, the x86/Makefile do not use the TEST_GEN_XXX, so if we found a better fix, we could convert x86/Makefile later. Regards Bamvor > > cheers > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html