Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755846AbdC1Mpm (ORCPT ); Tue, 28 Mar 2017 08:45:42 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:35587 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755218AbdC1Mpj (ORCPT ); Tue, 28 Mar 2017 08:45:39 -0400 MIME-Version: 1.0 In-Reply-To: <20170328093742.21528-1-tobias.regnery@gmail.com> References: <20170328093742.21528-1-tobias.regnery@gmail.com> From: Arnd Bergmann Date: Tue, 28 Mar 2017 14:38:19 +0200 X-Google-Sender-Auth: CmdBAMndSnZVsbvoTRdGMYEDLdU Message-ID: Subject: Re: [PATCH v2] of: add stubs for of_n_{addr, size}_cells To: Tobias Regnery Cc: Rob Herring , devicetree@vger.kernel.org, Linux Kernel Mailing List , Simon Horman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 20 On Tue, Mar 28, 2017 at 11:37 AM, Tobias Regnery wrote: > With CONFIG_OF=n and CONFIG_COMPILE_TEST=y the rcar pci-e driver fails to > build on arm: > > drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init': > drivers/pci/host/pcie-rcar.c:1035:16: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration] > parser->pna = of_n_addr_cells(node); > ^~~~~~~~~~~~~~~ > > Fix this by adding an inline stub for of_n_addr_cells > > While at it also provide a stub for of_n_size_cells for consistency reasons. > > Signed-off-by: Tobias Regnery > --- > Changes in v2: > - add a stub for of_n_size_cells as suggested by Arnd Acked-by: Arnd Bergmann