Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933148AbdC1NnG (ORCPT ); Tue, 28 Mar 2017 09:43:06 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:36738 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933117AbdC1NnD (ORCPT ); Tue, 28 Mar 2017 09:43:03 -0400 MIME-Version: 1.0 In-Reply-To: <368A8A18-0B9B-4733-86EF-D44C8E9CAE36@holtmann.org> References: <20170328132935.382216-1-arnd@arndb.de> <368A8A18-0B9B-4733-86EF-D44C8E9CAE36@holtmann.org> From: "Von Dentz, Luiz" Date: Tue, 28 Mar 2017 16:42:50 +0300 Message-ID: Subject: Re: [PATCH] 6lowpan: set peer_addr correctly again To: Marcel Holtmann Cc: Arnd Bergmann , "Gustavo F. Padovan" , Johan Hedberg , "David S. Miller" , Stefan Schmidt , Jukka Rissanen , Eric Dumazet , Patrik Flykt , Alexander Aring , Glenn Ruben Bakke , "linux-bluetooth@vger.kernel.org" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2SDl1Nn031104 Content-Length: 984 Lines: 27 Hi Marcel, On Tue, Mar 28, 2017 at 4:37 PM, Marcel Holtmann wrote: > Hi Arnd, > >> A bugfix accidentally changed one line to return the peer_addr >> from setup_header, causing it to become unused: >> >> net/bluetooth/6lowpan.c: In function 'setup_header': >> net/bluetooth/6lowpan.c:402:14: error: parameter 'peer_addr' set but not used [-Werror=unused-but-set-parameter] >> >> The only user of the variable is a subsequent printk(), and >> it is not otherwise initialized, so reverting the changed line >> looks like the right fix. >> >> Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth") >> Signed-off-by: Arnd Bergmann >> --- >> net/bluetooth/6lowpan.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > I took Colin’s patch since it showed up first in my inbox. Thanks, I might be missing something since the error doesn't show up for me: CC [M] net/bluetooth/6lowpan.o LD [M] net/bluetooth/bluetooth_6lowpan.o