Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755359AbdC1NZf (ORCPT ); Tue, 28 Mar 2017 09:25:35 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:36105 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146AbdC1NZ3 (ORCPT ); Tue, 28 Mar 2017 09:25:29 -0400 MIME-Version: 1.0 In-Reply-To: <20170323194618.26548-1-andriy.shevchenko@linux.intel.com> References: <20170323194618.26548-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Tue, 28 Mar 2017 15:24:59 +0200 Message-ID: Subject: Re: [PATCH v1 0/8] gpio: acpi: Make it working To: Andy Shevchenko Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , Dmitry Torokhov , Hans de Goede , "linux-kernel@vger.kernel.org" , Mika Westerberg , Jarkko Nikula , ACPI Devel Maling List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 29 On Thu, Mar 23, 2017 at 8:46 PM, Andy Shevchenko wrote: > Currently GPIO ACPI library provides an API to get a GPIO resources > (IO or interrupt) from ACPI tables for the individual drivers. > > This library has few flaws which makes some devices not working: > - the library allows to abuse ACPI by using a _CRS fallback mechanism > - the library neglects flags of the resource > > In this series: > - the _CRS fallback is forbidden > - the pin configuration follows what firmware wants to > - the documentation is updated in order to clarify corner cases > > After this series it's possible to use GPIO pins for input (interrupt) > which were configured as output by BIOS by some reason. It's a crucial > functionality for IoT open connected boards where user may choose any of > available pin for almost any of available function, including GPIO input > (interrupt). > > Current bad behaviour was first reported by Jarkko Nikula few months ago. I see there are some outstanding comments in the patches but it looks OK overall to me, waiting for a v2 before applying, please collect ACKs and relevant Tested-by:s. Yours, Linus Walleij