Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933123AbdC1NnC (ORCPT ); Tue, 28 Mar 2017 09:43:02 -0400 Received: from mga09.intel.com ([134.134.136.24]:14017 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933051AbdC1NnA (ORCPT ); Tue, 28 Mar 2017 09:43:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="81879710" From: Felipe Balbi To: Baolin Wang , gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, neilb@suse.com, jun.li@nxp.com, peter.chen@freescale.com, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH v2 2/2] usb: phy: phy-qcom-8x16-usb: Remove redundant extcon register/unregister In-Reply-To: References: <0b16763df04e197fb5b3c21b19799280d3bce275.1490248054.git.baolin.wang@linaro.org> Date: Tue, 28 Mar 2017 16:42:15 +0300 Message-ID: <87zig5frgo.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 457 Lines: 15 Hi, Baolin Wang writes: > Since usb phy core has added common code to register or unregister > extcon device, then phy-qcom-8x16-usb driver does not need its own > code to register/unregister extcon device, then remove them. > > Signed-off-by: Baolin Wang so previous patch helped *ONE* single user? Was it really beneficial if it's all for a single user? Which duplicated code did it remove? -- balbi