Subject: Re: [RFC PATCH 0/5] CFS load tracking trace events
To: Vincent Guittot <vincent.guittot@linaro.org>
References: <20170328063541.12912-1-dietmar.eggemann@arm.com>
 <CAKfTPtByOR1r8ATJrYnF=YeJDh+d4fKgZsntWwgS7PonjZsw0g@mail.gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Steven Rostedt <rostedt@goodmis.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Juri Lelli <juri.lelli@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <550d2e4e-96c0-11de-f674-ea0fea870948@arm.com>
Date: Tue, 28 Mar 2017 15:45:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAKfTPtByOR1r8ATJrYnF=YeJDh+d4fKgZsntWwgS7PonjZsw0g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 897
Lines: 29

On 03/28/2017 12:05 PM, Vincent Guittot wrote:
> On 28 March 2017 at 08:35, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:

[...]

>> The following keys are used to identify the cfs scheduler brick:
>>
>>  (1) Cpu number the cfs scheduler brick is attached to.
>>
>>  (2) Task_group path and (css) id.
>>
>>  (3) Task name and pid.
>
> Do you really need both path/name and id/pid ?
>
> The path/name looks quite intrusive so can't we just use id/pid ?

One problem is that all autogroups use id=0.

Another thing with task_groups is that dealing with path="/tg1/tg11" is 
so much more intuitive than id="7".

IMHO, we do need task name and pid to be able to clearly identify a task 
(same name/different pid or fork phase (forkee still has name of forker)).

You're right, the implementation with path is more complicated but I 
guess that's worth it. We could get rid of 'id' though.

[...]