Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbdC1OEA (ORCPT ); Tue, 28 Mar 2017 10:04:00 -0400 Received: from foss.arm.com ([217.140.101.70]:49650 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbdC1ODo (ORCPT ); Tue, 28 Mar 2017 10:03:44 -0400 Subject: Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event To: Peter Zijlstra References: <20170328063541.12912-1-dietmar.eggemann@arm.com> <20170328063541.12912-5-dietmar.eggemann@arm.com> <20170328080528.okzd74dl4gl6fh4c@hirez.programming.kicks-ass.net> Cc: Ingo Molnar , LKML , Matt Fleming , Vincent Guittot , Steven Rostedt , Morten Rasmussen , Juri Lelli , Patrick Bellasi From: Dietmar Eggemann Message-ID: <4b0fb4a2-90e0-38cb-aea5-bbfe8efaf65c@arm.com> Date: Tue, 28 Mar 2017 16:03:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170328080528.okzd74dl4gl6fh4c@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 30 On 03/28/2017 10:05 AM, Peter Zijlstra wrote: > On Tue, Mar 28, 2017 at 07:35:40AM +0100, Dietmar Eggemann wrote: >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 04d4f81b96ae..d1dcb19f5b55 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -2940,6 +2940,8 @@ __update_load_avg(u64 now, int cpu, struct sched_avg *sa, >> >> if (cfs_rq) >> trace_sched_load_cfs_rq(cfs_rq); >> + else >> + trace_sched_load_se(container_of(sa, struct sched_entity, avg)); >> >> return decayed; >> } >> @@ -3162,6 +3164,7 @@ static inline int propagate_entity_load_avg(struct sched_entity *se) >> update_tg_cfs_load(cfs_rq, se); >> >> trace_sched_load_cfs_rq(cfs_rq); >> + trace_sched_load_se(se); >> >> return 1; >> } > > Having back-to-back tracepoints is disgusting. Yeah, but avoiding putting them like this is hard since the calls to update_tg_cfs_util() and update_tg_cfs_load() inside propagate_entity_load_avg() refresh util for the cfs_rq and the se respectively load (and runnable_load).