Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbdC1Oi3 (ORCPT ); Tue, 28 Mar 2017 10:38:29 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:35194 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752131AbdC1Oi1 (ORCPT ); Tue, 28 Mar 2017 10:38:27 -0400 Subject: Re: [PATCH v3 3/3] perf annotate: Fix missing number of samples To: Arnaldo Carvalho de Melo References: <1490598638-13947-1-git-send-email-treeze.taeung@gmail.com> <1490598638-13947-4-git-send-email-treeze.taeung@gmail.com> <20170327182631.GC27431@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Masami Hiramatsu , Jiri Olsa , =?UTF-8?Q?Martin_Li=c5=a1ka?= From: Taeung Song Message-ID: Date: Tue, 28 Mar 2017 23:38:06 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2197 Lines: 68 On 03/28/2017 09:09 PM, Taeung Song wrote: > Good morning, Arnaldo :) > > On 03/28/2017 03:26 AM, Arnaldo Carvalho de Melo wrote: >> Em Mon, Mar 27, 2017 at 04:10:38PM +0900, Taeung Song escreveu: >>> If running 'perf annotate --stdio -l --show-total-period', >>> you can see a problem showing only zero '0' for number of samples. >>> >>> Before: >>> $ perf annotate --stdio -l --show-total-period >>> ... >>> 0 : 400816: push %rbp >>> 0 : 400817: mov %rsp,%rbp >>> 0 : 40081a: mov %edi,-0x24(%rbp) >>> 0 : 40081d: mov %rsi,-0x30(%rbp) >>> 0 : 400821: mov -0x24(%rbp),%eax >>> 0 : 400824: mov -0x30(%rbp),%rdx >>> 0 : 400828: mov (%rdx),%esi >>> 0 : 40082a: mov $0x0,%edx >>> ... >>> >>> The reason is number of samples aren't set >>> in symbol__get_source_line(). so set it ordinarily. >> >> Can you please take a look at: >> >> 0c4a5bcea460 ("perf annotate: Display total number of samples with >> --show-total-period") >> >> that introduced the --show-total-period code and take it into account in >> this fix? >> >> I.e. from a quick look it did the calculation setting that field in the >> TUI code, where it should have done in the util/annotate.c file, so that >> all UIs would be able to use it. >> Sorry, I misunderstood what you said. Already there is the calculation setting in util/annotate.c Because of the cset e64aa75bf5 ("perf annotate browser: Use disasm__calc_percent()") by Namhyung. So I think that we don't need to do as you guess. Thanks, Taeung >> After your analysis, please add a Fixes: that cset, ok? >> >> I applied the other two patches and added Martin to the CC list, as he >> is the author of that patch and may have something to say here. >> >> - Arnaldo >> > > Okey! I look into the cset 0c4a5bcea460. > > It is fine but if running 'show-total-period' with '-l', > the problem happen. The reason is to miss setting number of samples > for source_line_samples, so will send v4 added Fixes: and Cc: Martin > (and a bit changed commit log message) > > Thanks, > Taeung