Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932155AbdC1Osn (ORCPT ); Tue, 28 Mar 2017 10:48:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:47872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082AbdC1Osk (ORCPT ); Tue, 28 Mar 2017 10:48:40 -0400 Date: Tue, 28 Mar 2017 10:47:55 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Dietmar Eggemann , Ingo Molnar , LKML , Matt Fleming , Vincent Guittot , Morten Rasmussen , Juri Lelli , Patrick Bellasi Subject: Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking trace event Message-ID: <20170328104755.4f03a68e@gandalf.local.home> In-Reply-To: <20170328080050.yajakazk5v3njwqi@hirez.programming.kicks-ass.net> References: <20170328063541.12912-1-dietmar.eggemann@arm.com> <20170328063541.12912-3-dietmar.eggemann@arm.com> <20170328080050.yajakazk5v3njwqi@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 496 Lines: 15 On Tue, 28 Mar 2017 10:00:50 +0200 Peter Zijlstra wrote: > On Tue, Mar 28, 2017 at 07:35:38AM +0100, Dietmar Eggemann wrote: > > > > + if (cfs_rq) > > + trace_sched_load_cfs_rq(cfs_rq); > > You can do that with DEFINE_EVENT_CONDITION and TP_CONDITION. I just read this after I replied about using TRACE_EVENT_CONDITION. As there is not a DEFINE_EVENT(), the TRACE_EVENT_CONDITION() should be used. All the locations expect cfs_rq to not be NULL I assume. -- Steve