Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbdC1PaC (ORCPT ); Tue, 28 Mar 2017 11:30:02 -0400 Received: from mail.kernel.org ([198.145.29.136]:58324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdC1PaA (ORCPT ); Tue, 28 Mar 2017 11:30:00 -0400 Date: Wed, 29 Mar 2017 00:29:29 +0900 From: Masami Hiramatsu To: Ravi Bangoria Cc: acme@redhat.com, alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au, hemant@linux.vnet.ibm.com Subject: Re: [PATCH v3 0/3] perf/sdt: Hardening argument support Message-Id: <20170329002929.54e022d61751a84221a4635e@kernel.org> In-Reply-To: <20170328094754.3156-1-ravi.bangoria@linux.vnet.ibm.com> References: <20170328094754.3156-1-ravi.bangoria@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2020 Lines: 60 Hi Arnaldo, please pull this, I've already acked to this series. Thank you, On Tue, 28 Mar 2017 15:17:51 +0530 Ravi Bangoria wrote: > SDT event argument support on x86 is recently added to Perf. But > there are couple of issues with it. > > It lacks renaming mapping for few 8 bit registers: al, bl, cl, dl, > ah, bh, ch and dh. SDT events using these registers in arguments > are failing at 'perf probe'. Add renaming logic to them. (patch 1) > > It still has x86 specific code in general code. It also fails to > convert arguments having no offset but still surrounds register with > parenthesis for ex. 8@(%rdi) is converted to +(%di):u64, which is > rejected by uprobe_events. Also, 'perf probe' is failing for *all SDT > events on all archs except x86*. Solve these issues. (patch 2) > > Add argument parser for powerpc. (patch 3) > > Changes in v3: > - (patch 1) Add renaming entries for ah, bh, ch and dh registers.[1] > > - (patch 1) v2 contains silly copy-paste error. It maps all al, bl... > registers to ax. Fix that. > > - (patch 2) Fix typo 'constant'. > > - Patch 2 is not applying cleanly on top of patch 1 after adding > ah, bh... registers. Fix that. > > v2: https://lkml.org/lkml/2017/3/27/118 > > This patch is prepared on top of acme/perf/core. > > [1] https://lkml.org/lkml/2017/3/27/462 > > Ravi Bangoria (3): > perf/sdt/x86: Add renaming logic for (missing) 8 bit registers > perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ > perf/sdt/powerpc: Add argument support > > tools/perf/arch/powerpc/util/perf_regs.c | 111 ++++++++++++++++++ > tools/perf/arch/x86/util/perf_regs.c | 187 +++++++++++++++++++++++++------ > tools/perf/util/perf_regs.c | 6 +- > tools/perf/util/perf_regs.h | 11 +- > tools/perf/util/probe-file.c | 132 +++++++--------------- > 5 files changed, 313 insertions(+), 134 deletions(-) > > -- > 2.9.3 > -- Masami Hiramatsu