Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754667AbdC1QlZ (ORCPT ); Tue, 28 Mar 2017 12:41:25 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:36389 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbdC1QlX (ORCPT ); Tue, 28 Mar 2017 12:41:23 -0400 Date: Tue, 28 Mar 2017 18:41:10 +0200 From: Peter Zijlstra To: Dietmar Eggemann Cc: Ingo Molnar , LKML , Matt Fleming , Vincent Guittot , Steven Rostedt , Morten Rasmussen , Juri Lelli , Patrick Bellasi Subject: Re: [RFC PATCH 4/5] sched/events: Introduce sched_entity load tracking trace event Message-ID: <20170328164110.gcejuwpelhhiblpv@hirez.programming.kicks-ass.net> References: <20170328063541.12912-1-dietmar.eggemann@arm.com> <20170328063541.12912-5-dietmar.eggemann@arm.com> <20170328080824.uujenx4e6n5kwk5d@hirez.programming.kicks-ass.net> <4162eba0-47f0-f695-42e9-66655b11a50a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4162eba0-47f0-f695-42e9-66655b11a50a@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 254 Lines: 7 On Tue, Mar 28, 2017 at 04:13:45PM +0200, Dietmar Eggemann wrote: > Do you think that making them public in include/linux/sched.h is the way to > go? No; all that stuff should really stay private. tracepoints are a very bad reason to leak this stuff.