Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755360AbdC1RiS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Mar 2017 13:38:18 -0400
Received: from mail.kernel.org ([198.145.29.136]:58592 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752258AbdC1RiR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Mar 2017 13:38:17 -0400
Date: Tue, 28 Mar 2017 13:37:44 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Juri Lelli <juri.lelli@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>
Subject: Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking
 trace event
Message-ID: <20170328133744.0d93fe83@gandalf.local.home>
In-Reply-To: <20170328133626.5632da53@gandalf.local.home>
References: <20170328063541.12912-1-dietmar.eggemann@arm.com>
        <20170328063541.12912-3-dietmar.eggemann@arm.com>
        <20170328104600.18d36cb0@gandalf.local.home>
        <20170328164459.tkiqbtb7yaplygng@hirez.programming.kicks-ass.net>
        <20170328133626.5632da53@gandalf.local.home>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 357
Lines: 11

On Tue, 28 Mar 2017 13:36:26 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> But why play games, and rely on the design of the code? A
> TRACE_EVENT_CONDTION() is more robust and documents that this
> tracepoint should not be called when cfs_rq is NULL.

In other words, what are you trying to save for not using the
TRACE_EVENT_CONDITION()?

-- Steve