Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755270AbdC1SCY (ORCPT ); Tue, 28 Mar 2017 14:02:24 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36169 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbdC1SCW (ORCPT ); Tue, 28 Mar 2017 14:02:22 -0400 From: jes.sorensen@gmail.com X-Google-Original-From: Jes.Sorensen@gmail.com To: Gioh Kim Cc: neilb@suse.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Jack Wang Subject: Re: [PATCHv2 1/2] super1: ignore failfast flag for setting device role References: <1490003517-4216-1-git-send-email-gi-oh.kim@profitbricks.com> <1490003517-4216-2-git-send-email-gi-oh.kim@profitbricks.com> Date: Tue, 28 Mar 2017 14:01:58 -0400 In-Reply-To: <1490003517-4216-2-git-send-email-gi-oh.kim@profitbricks.com> (Gioh Kim's message of "Mon, 20 Mar 2017 10:51:56 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 666 Lines: 22 Gioh Kim writes: > There is corner case for setting device role, > if new device has failfast flag. > The failfast flag should be ignored. > > Signed-off-by: Gioh Kim > Signed-off-by: Jack Wang > --- > super1.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Applied! Ideally I would like to get rid of the hardcoded values and use the bit defines instead, but the original code did the same, so I am going to take it. I am leaving out the second patch for now, per Neil's comments. If you feel strongly about it, please conveince Neil first :) Thanks, Jes