Date: Tue, 28 Mar 2017 20:18:15 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Juri Lelli <juri.lelli@arm.com>
Subject: Re: [RFC PATCH 2/5] sched/events: Introduce cfs_rq load tracking
 trace event
Message-ID: <20170328181815.m243aymvimyidiq2@hirez.programming.kicks-ass.net>
References: <20170328063541.12912-1-dietmar.eggemann@arm.com>
 <20170328063541.12912-3-dietmar.eggemann@arm.com>
 <20170328104600.18d36cb0@gandalf.local.home>
 <20170328164459.tkiqbtb7yaplygng@hirez.programming.kicks-ass.net>
 <20170328165754.u3nwxjveyhkh75fo@hirez.programming.kicks-ass.net>
 <20170328172005.GF11362@e110439-lin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170328172005.GF11362@e110439-lin>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 718
Lines: 19

On Tue, Mar 28, 2017 at 06:20:05PM +0100, Patrick Bellasi wrote:
> On 28-Mar 18:57, Peter Zijlstra wrote:
> > On Tue, Mar 28, 2017 at 06:44:59PM +0200, Peter Zijlstra wrote:

> > > +static int
> > > +__update_load_avg(u64 now, int cpu, struct sched_avg *sa,
> > > +		  unsigned long weight, int running, struct cfs_rq *cfs_rq)
> 
>                   __attribute__((nonnull (6)));
> 
> > > +{
> > > +	return ___update_load_avg(now, cpu, sa, weight, running, cfs_rq);
> > 
> > Although ideally we'd be able to tell the compiler that cfs_rq will not
> > be NULL here. Hurmph.. no __builtin for that I think :/
> 
> What about the above attribute?

Ooh, shiny, thanks! My bad for failing to check the function attributes.