Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932229AbdC1SxT (ORCPT ); Tue, 28 Mar 2017 14:53:19 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34686 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755119AbdC1SxP (ORCPT ); Tue, 28 Mar 2017 14:53:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490383336-23117-1-git-send-email-jliang@xilinx.com> From: Wendy Liang Date: Tue, 28 Mar 2017 11:52:53 -0700 Message-ID: Subject: Re: [RFC LINUX PATCH 0/3] Allow remote to specify shared memory To: Suman Anna Cc: Wendy Liang , Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Wendy Liang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 46 Thanks Suman for your comments. On Mon, Mar 27, 2017 at 8:54 AM, Suman Anna wrote: > Hi Wendy, > > On 03/24/2017 02:22 PM, Wendy Liang wrote: >> This patch enables the remoteproc to specify the shared memory. >> Remoteproc declared this memory as DMA memory. >> It can be used for virtio, or shared buffers. > > You should be able to achieve this without any remoteproc core changes. > You can do this by defining a reserved-memory node in your DTS file (can > be a CMA pool or a DMA pool), assigning the node using memory-region in > your remoteproc DT node and using the function, > of_reserved_mem_device_init() in your remoteproc driver. The idea to introduce the rproc_mem is to let the remote to specify the shared memory. I am trying to see if there is a way to specify this software attribute without touching the device tree as it doesn't look like it is hardware related. And try to see if there is a way that when I change the firmware, i don't need to change the device tree. Thanks, Wendy > > regards > Suman > >> >> Wendy Liang (3): >> remoteproc: add rproc mem resource entry >> remoteproc: add rproc_mem resource entry handler >> remoteproc: Release DMA declare mem when cleanup rsc >> >> drivers/remoteproc/remoteproc_core.c | 40 ++++++++++++++++++++++++++++++++++++ >> include/linux/remoteproc.h | 23 ++++++++++++++++++++- >> 2 files changed, 62 insertions(+), 1 deletion(-) >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html