Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932358AbdC1T3l (ORCPT ); Tue, 28 Mar 2017 15:29:41 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:36457 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932091AbdC1T3h (ORCPT ); Tue, 28 Mar 2017 15:29:37 -0400 Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: unconditionally set ATU trunk To: Vivien Didelot , netdev@vger.kernel.org References: <20170328190943.18320-1-vivien.didelot@savoirfairelinux.com> Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn From: Florian Fainelli Message-ID: <29073565-c03a-f684-6b49-b5226cbdd61b@gmail.com> Date: Tue, 28 Mar 2017 12:29:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170328190943.18320-1-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1148 Lines: 37 On 03/28/2017 12:09 PM, Vivien Didelot wrote: > Set the trunk member of the mv88e6xxx_atu_entry structure regardless its > value, so that uninitialized structures gets the correct boolean value. Ouch, yes indeed! > > Note that no mainline code is affected by the current behavior. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli > --- > drivers/net/dsa/mv88e6xxx/global1_atu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6xxx/global1_atu.c b/drivers/net/dsa/mv88e6xxx/global1_atu.c > index 831434bc5c13..fa7e7db5171b 100644 > --- a/drivers/net/dsa/mv88e6xxx/global1_atu.c > +++ b/drivers/net/dsa/mv88e6xxx/global1_atu.c > @@ -128,9 +128,7 @@ static int mv88e6xxx_g1_atu_data_read(struct mv88e6xxx_chip *chip, > > entry->state = val & 0xf; > if (entry->state != GLOBAL_ATU_DATA_STATE_UNUSED) { > - if (val & GLOBAL_ATU_DATA_TRUNK) > - entry->trunk = true; > - > + entry->trunk = !!(val & GLOBAL_ATU_DATA_TRUNK); > entry->portvec = (val >> 4) & mv88e6xxx_port_mask(chip); > } > > -- Florian