Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755137AbdC1VNe (ORCPT ); Tue, 28 Mar 2017 17:13:34 -0400 Received: from mail-bn3nam01on0066.outbound.protection.outlook.com ([104.47.33.66]:35293 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752363AbdC1VNd (ORCPT ); Tue, 28 Mar 2017 17:13:33 -0400 From: "Deucher, Alexander" To: "'Joerg Roedel'" CC: "'Joerg Roedel'" , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Drake , "Nath, Arindam" Subject: RE: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Thread-Topic: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS Thread-Index: AQHSp70w+OLXANWfy0m3Sq7/yXBLO6GqsIHAgAADzgCAAACekIAABxQAgAABsSA= Date: Tue, 28 Mar 2017 21:13:23 +0000 Message-ID: References: <1490703404-4944-1-git-send-email-joro@8bytes.org> <20170328202844.GQ8329@suse.de> <20170328205616.GR8329@suse.de> In-Reply-To: <20170328205616.GR8329@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.55.251] x-microsoft-exchange-diagnostics: 1;BN6PR12MB1508;7:lhm6BWG2+2PhFpjrcopcz2/Gok6AO4C0UX26qoh/K9QVBcWV+6AFEzZG6M7caqbNjId1ae6uW1OpIGy06Ec6l2u4Wfo7+l3IBjfv5mszh8CjWI1W3wRajzAyMLUolUbx0sEgOiVZ2sSbA9DmyvVZkjgZAgcT5QQr4UchuiaEi9twKzqdZAhmKBedpfy+ajn4PYG5IWzhEPN0W6f5EyY/od//Bct8IZ8y7q219uhvfJ3wxbXtXKjiZSiL/nnRw84nhSL7lzmCsF8eaOxbH07Y+uIky6JdEmMBL/A9RFpdFX7MWK6FG07PNPiUgL/7bZmSuarFOpogVp0+jjnbiEbBEw==;20:Lx09feDGQBKBPcpDb8V1iM8Prkg/LdP9yzAHd27JZboky3eVjlzRfm7rOzbCOpHEuY1SAUboK+/enNlUZnGx3x5JQhPMPzuLQISlToYCh0zxDGgqhOS0DqzvRimgqwaSFHM754pRLciSsQYOzVbxV6Ku/UW+59sIil+UzSSpE0qYq1Ni797tmtIgQAz7sz0KKPmZFqyRvz0tesrR14qJtOSlV+X9SXCvDUjjh9/RODV0tJOGM/AXKIm/bBwDAXrH x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(39850400002)(39400400002)(39410400002)(39840400002)(39450400003)(377454003)(13464003)(24454002)(7696004)(6916009)(2900100001)(93886004)(66066001)(2950100002)(77096006)(6506006)(6436002)(9686003)(55016002)(99286003)(53936002)(54906002)(5660300001)(305945005)(74316002)(122556002)(189998001)(76176999)(54356999)(50986999)(25786009)(53546009)(229853002)(4326008)(7736002)(86362001)(3846002)(102836003)(6116002)(8676002)(8936002)(3280700002)(2906002)(3660700001)(110136004)(6246003)(33656002)(81166006)(38730400002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1508;H:BN6PR12MB1652.namprd12.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: 74117154-8b26-4664-6588-08d4761f44e5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423066)(201703031133072);SRVR:BN6PR12MB1508; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040441)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(201703131423066)(201702281528066)(201703061421066)(201703061406066)(20161123558025)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:BN6PR12MB1508;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1508; x-forefront-prvs: 0260457E99 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2017 21:13:23.5418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1508 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2SLEnfQ012178 Content-Length: 1076 Lines: 21 > -----Original Message----- > From: 'Joerg Roedel' [mailto:jroedel@suse.de] > Sent: Tuesday, March 28, 2017 4:56 PM > To: Deucher, Alexander > Cc: 'Joerg Roedel'; Bjorn Helgaas; linux-pci@vger.kernel.org; linux- > kernel@vger.kernel.org; Daniel Drake; Nath, Arindam > Subject: Re: [PATCH] PCI: Blacklist AMD Stoney GPU devices for ATS > > On Tue, Mar 28, 2017 at 08:37:01PM +0000, Deucher, Alexander wrote: > > The question is, could the problem stem from flushing an entity that > > didn't request it, or should that not matter? I guess it shouldn't > > matter otherwise we'd see this on other platforms like Carrizo as > > well. > > What do you mean by "didn't request it"? The IOMMU driver only sends > io/tlb invalidations to devices it enabled ATS on. If I understand Arindam's patch correctly, it only flushes TLB entries for domains in the flush queue whereas the previous behavior was to flush all domains. If there was no TLB flush in the queue for that domain, could flushing it cause a problem? Sorry, I'm not too familiar with the IOMMU code or ATS. Alex