Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930AbdC1WCp (ORCPT ); Tue, 28 Mar 2017 18:02:45 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53448 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbdC1WCm (ORCPT ); Tue, 28 Mar 2017 18:02:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F53860764 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] acpi: apei: check for pending errors when probing HED type GHES entries To: ahs3@redhat.com, rjw@rjwysocki.net, lenb@kernel.org, bp@suse.de, prarit@redhat.com, bhelgaas@google.com, punit.agrawal@arm.com, mingo@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, shiju.jose@huawei.com, James.Morse@arm.com References: <1490732054-4720-1-git-send-email-tbaicar@codeaurora.org> From: "Baicar, Tyler" Message-ID: <39260c84-8708-c63a-6568-868061a13455@codeaurora.org> Date: Tue, 28 Mar 2017 16:02:34 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 49 On 3/28/2017 4:00 PM, Al Stone wrote: > On 03/28/2017 02:14 PM, Tyler Baicar wrote: >> If a HED type error occurs prior to GHES probing, the kernel will >> never report the error. The HED driver will see that no notifiers >> are registers, and clear the interrupt. > ..."registers" or "registered"? Oops :) I'll fix that to say registered. Thanks, Tyler > >> This becomes a more serious problem with firmware that supports >> GHESv2 acknowledgements from the kernel. The firmware will populate >> the error and wait for the kernel ack. But since the kernel will >> never process the error we get into a state that the firmware will >> not send any more errors and the kernel will never see or ack the >> original error. >> >> Check for pending errors when probing HED type GHES entries to >> avoid the above situation. >> >> This patch is based on Shiju's patch that adds support for GSIV >> and GPIO notification types: >> https://patchwork.kernel.org/patch/9628817/ >> >> Signed-off-by: Tyler Baicar >> --- >> drivers/acpi/apei/ghes.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index fd39929..cf5e938 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -1035,6 +1035,7 @@ static int ghes_probe(struct platform_device *ghes_dev) >> register_acpi_hed_notifier(&ghes_notifier_hed); >> list_add_rcu(&ghes->list, &ghes_hed); >> mutex_unlock(&ghes_list_mutex); >> + ghes_proc(ghes); >> break; >> case ACPI_HEST_NOTIFY_NMI: >> ghes_nmi_add(ghes); >> > -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.