Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755831AbdC1WO3 (ORCPT ); Tue, 28 Mar 2017 18:14:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59682 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755030AbdC1WO1 (ORCPT ); Tue, 28 Mar 2017 18:14:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DDE25607E6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org Reply-To: shankerd@codeaurora.org Subject: Re: [PATCH] ACPI : Update platform device numa node based on _PXM method References: <1490108070-24061-1-git-send-email-shankerd@codeaurora.org> <1932728.uFK6bUjlgv@aspire.rjw.lan> To: "Rafael J. Wysocki" Cc: Len Brown , linux-acpi , linux-kernel , Vikram Sethi From: Shanker Donthineni Message-ID: <6b298342-2746-f6d5-0b0e-67c20fd4c002@codeaurora.org> Date: Tue, 28 Mar 2017 17:14:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1932728.uFK6bUjlgv@aspire.rjw.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 46 Hi Rafael, On 03/28/2017 04:43 PM, Rafael J. Wysocki wrote: > On Tuesday, March 21, 2017 09:54:30 AM Shanker Donthineni wrote: >> The optional _PXM method evaluates to an integer that identifies the >> proximity domain of a device object. This patch implements support for >> ACPI _PXM method and updates the platform device numa node id using >> acpi_get_node(), which provides the PXM to NUMA mapping information. >> >> Signed-off-by: Shanker Donthineni > What exactly is the motivation here? We have a couple of platform devices some of them are attached to socket0 and others to a different socket. We would like to covert memory allocations in Qualcomm platform device drivers to a NUMA aware allocation to improve performance. >> --- >> drivers/acpi/acpi_platform.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c >> index b4c1a6a..83d953e 100644 >> --- a/drivers/acpi/acpi_platform.c >> +++ b/drivers/acpi/acpi_platform.c >> @@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev, >> if (IS_ERR(pdev)) >> dev_err(&adev->dev, "platform device creation failed: %ld\n", >> PTR_ERR(pdev)); >> - else >> + else { >> + set_dev_node(&pdev->dev, acpi_get_node(adev->handle)); >> dev_dbg(&adev->dev, "created platform device %s\n", >> dev_name(&pdev->dev)); >> + } >> >> kfree(resources); >> + >> return pdev; >> } >> EXPORT_SYMBOL_GPL(acpi_create_platform_device); >> -- Shanker Donthineni Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.