Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932572AbdC1Wrp (ORCPT ); Tue, 28 Mar 2017 18:47:45 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33983 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbdC1Wrm (ORCPT ); Tue, 28 Mar 2017 18:47:42 -0400 Date: Wed, 29 Mar 2017 01:47:20 +0300 From: "Kirill A. Shutemov" To: "H. Peter Anvin" Cc: "Kirill A. Shutemov" , Linus Torvalds , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Andi Kleen , Dave Hansen , Andy Lutomirski , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] x86/mm: Define virtual memory map for 5-level paging Message-ID: <20170328224720.7ir7godugb6eqzm5@node.shutemov.name> References: <20170327162925.16092-1-kirill.shutemov@linux.intel.com> <20170327162925.16092-4-kirill.shutemov@linux.intel.com> <1ae86ad3-deae-1b27-d7a9-ea6b20edc039@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ae86ad3-deae-1b27-d7a9-ea6b20edc039@zytor.com> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 476 Lines: 16 On Tue, Mar 28, 2017 at 03:21:39PM -0700, H. Peter Anvin wrote: > On 03/27/17 09:29, Kirill A. Shutemov wrote: > > +fffe000000000000 - fffe007fffffffff (=39 bits) %esp fixup stacks > > Why move this? You're right. There's no reason to. It's accident due to ESPFIX_BASE_ADDR being defined using PGDIR_SHIFT. We should use P4D_SHIFT instead to produce consistent result across paging modes. I'll update the patch tomorrow. Thanks for noticing this. -- Kirill A. Shutemov