Date: Wed, 29 Mar 2017 02:30:56 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>,
        Shaohua Li <shli@kernel.org>, Minchan Kim <minchan@kernel.org>,
        Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH -mm -v7 1/9] mm, swap: Make swap cluster size same of THP
 size on x86_64
Message-ID: <20170328233056.zkp733h5kij7lfdb@node.shutemov.name>
References: <20170328053209.25876-1-ying.huang@intel.com>
 <20170328053209.25876-2-ying.huang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170328053209.25876-2-ying.huang@intel.com>
User-Agent: NeoMutt/20170306 (1.8.0)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 874
Lines: 21

On Tue, Mar 28, 2017 at 01:32:01PM +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
> 
> In this patch, the size of the swap cluster is changed to that of the
> THP (Transparent Huge Page) on x86_64 architecture (512).  This is for
> the THP swap support on x86_64.  Where one swap cluster will be used to
> hold the contents of each THP swapped out.  And some information of the
> swapped out THP (such as compound map count) will be recorded in the
> swap_cluster_info data structure.
> 
> For other architectures which want THP swap support,
> ARCH_USES_THP_SWAP_CLUSTER need to be selected in the Kconfig file for
> the architecture.

Intreseting case could be architecture with HPAGE_PMD_NR < 256.
Can current code pack more than one THP per claster.

If not we need to have BUILG_BUG_ON() to catch attempt of such enabling.

-- 
 Kirill A. Shutemov