Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbdC2CCe (ORCPT ); Tue, 28 Mar 2017 22:02:34 -0400 Received: from mail-ot0-f194.google.com ([74.125.82.194]:33987 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbdC2CCc (ORCPT ); Tue, 28 Mar 2017 22:02:32 -0400 Date: Tue, 28 Mar 2017 21:02:29 -0500 From: Rob Herring To: David Rivshin Cc: Dmitry Torokhov , Mark Rutland , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: matrix_keypad: add option to drive inactive columns Message-ID: <20170329020229.dm3y57dlzjwilifm@rob-hp-laptop> References: <20170322201650.9072-1-drivshin@awxrd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170322201650.9072-1-drivshin@awxrd.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 16 On Wed, Mar 22, 2017 at 04:16:50PM -0400, David Rivshin wrote: > From: David Rivshin > > The gpio-matrix-keypad driver normally sets inactive columns as inputs > while scanning. This does not work for all hardware, which may require > the inactive columns to be actively driven in order to overcome any > pull-ups/downs on the columns. > > Signed-off-by: David Rivshin > --- > .../devicetree/bindings/input/gpio-matrix-keypad.txt | 2 ++ > drivers/input/keyboard/matrix_keypad.c | 13 +++++++++---- > include/linux/input/matrix_keypad.h | 3 +++ > 3 files changed, 14 insertions(+), 4 deletions(-) Acked-by: Rob Herring