Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbdC2CJm (ORCPT ); Tue, 28 Mar 2017 22:09:42 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:35420 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbdC2CJk (ORCPT ); Tue, 28 Mar 2017 22:09:40 -0400 MIME-Version: 1.0 In-Reply-To: <39ba92bacf48da957f8f85d5cb11d3254fe3d68f.1490595641.git.nandor.han@ge.com> References: <39ba92bacf48da957f8f85d5cb11d3254fe3d68f.1490595641.git.nandor.han@ge.com> From: Linus Walleij Date: Wed, 29 Mar 2017 04:09:38 +0200 Message-ID: Subject: Re: [PATCH 2/3] doc,dts - add XRA1403 DTS binding documentation To: Nandor Han Cc: Alexandre Courbot , Rob Herring , Mark Rutland , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 25 On Mon, Mar 27, 2017 at 8:23 AM, Nandor Han wrote: > Add the XRA1403 DTS binding documentation. > > Signed-off-by: Nandor Han There is no big problem with this but: > +The XRA1403 is an 16-bit GPIO expander with an SPI interface. Features available: > + - Individually programmable inputs: > + - Internal pull-up resistors > + - Polarity inversion > + - Individual interrupt enable > + - Rising edge and/or Falling edge interrupt > + - Input filter Since you mention that it has interrupts maybe you want to add bindings for the cascaded interrupt and the interrupt-controller; keyword etc already now. We just document what the hardware can do, we don't have to do all of it in the first Linux driver submission. Yours, Linus Walleij