Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbdC2C6e (ORCPT ); Tue, 28 Mar 2017 22:58:34 -0400 Received: from mail.kernel.org ([198.145.29.136]:33086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbdC2C6d (ORCPT ); Tue, 28 Mar 2017 22:58:33 -0400 Date: Wed, 29 Mar 2017 10:57:44 +0800 From: Shawn Guo To: Leonard Crestez Cc: Dong Aisheng , Sascha Hauer , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Fugang Duan , Octavian Purdila , Florian Fainelli , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Message-ID: <20170329025742.GU30608@dragon> References: <82d0aeeaed87ae5c9390b889cef4c54d715cde61.1490191972.git.leonard.crestez@nxp.com> <20170324064318.GD12604@b29396-OptiPlex-7040> <1490699810.3546.10.camel@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490699810.3546.10.camel@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1100 Lines: 27 On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote: > On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote: > > Hi Leonard, > > > > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > > > > > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > > > Add this driver to the default imx config since the device is present on > > > one of the evaluation boards. > > Upstream currently no evaluation board support. > > > > This may leave to Shawn to decide whether apply it. > > Really? But the dts for this eval board is included in upstream. Shouldn't the > default config try to work with the default imx*.dts files included? > > > > This used to work mostly fine with the generic phy driver but since > > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer > > I guess you should get a checkpatch error here. > > Because I didn't reference that other commit right? Sorry about this. > > Should I submit again with an improved commit message? Yes, please, and make sure that checkpatch.pl is happy about the patch. Shawn