Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbdC2Ezk (ORCPT ); Wed, 29 Mar 2017 00:55:40 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:51804 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbdC2Ezi (ORCPT ); Wed, 29 Mar 2017 00:55:38 -0400 X-IronPort-AV: E=Sophos;i="5.36,239,1486450800"; d="scan'208";a="673249" From: To: , CC: , , Subject: RE: [PATCH v2 10/11] ARM: at91: pm: Remove at91_pm_set_standby Thread-Topic: [PATCH v2 10/11] ARM: at91: pm: Remove at91_pm_set_standby Thread-Index: AQHSp7U4b2WPyqprAkeQjBaWTxJ5kKGrQctw Date: Wed, 29 Mar 2017 04:55:17 +0000 Message-ID: References: <20170328111938.21297-1-alexandre.belloni@free-electrons.com> <20170328111938.21297-11-alexandre.belloni@free-electrons.com> In-Reply-To: <20170328111938.21297-11-alexandre.belloni@free-electrons.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.76.4] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2T4u1or008119 Content-Length: 1994 Lines: 63 > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: 2017??3??28?? 19:20 > To: Nicolas Ferre - M43238 > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Boris > Brezillon ; Wenyou Yang - A41535 > ; Alexandre Belloni electrons.com> > Subject: [PATCH v2 10/11] ARM: at91: pm: Remove at91_pm_set_standby > > Merge at91_pm_set_standby() in at91_dt_ramc as this is the only callsite. > That moves it to the init section. > > Signed-off-by: Alexandre Belloni Acked-by: Wenyou Yang > --- > arch/arm/mach-at91/pm.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index > dedfe9038336..2cd27c830ab6 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -205,12 +205,6 @@ static struct platform_device at91_cpuidle_device = { > .name = "cpuidle-at91", > }; > > -static void at91_pm_set_standby(void (*at91_standby)(void)) -{ > - if (at91_standby) > - at91_cpuidle_device.dev.platform_data = at91_standby; > -} > - > /* > * The AT91RM9200 goes into self-refresh mode with this command, and will > * terminate self-refresh automatically on the next SDRAM access. > @@ -354,7 +348,7 @@ static __init void at91_dt_ramc(void) > struct device_node *np; > const struct of_device_id *of_id; > int idx = 0; > - const void *standby = NULL; > + void *standby = NULL; > const struct ramc_info *ramc; > > for_each_matching_node_and_match(np, ramc_ids, &of_id) { @@ -378,7 > +372,7 @@ static __init void at91_dt_ramc(void) > return; > } > > - at91_pm_set_standby(standby); > + at91_cpuidle_device.dev.platform_data = standby; > } > > static void at91rm9200_idle(void) > -- > 2.11.0 Best Regards, Wenyou Yang