Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754165AbdC2H3i (ORCPT ); Wed, 29 Mar 2017 03:29:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53754 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020AbdC2H3h (ORCPT ); Wed, 29 Mar 2017 03:29:37 -0400 Date: Wed, 29 Mar 2017 09:19:46 +0200 From: Greg KH To: aviyae Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: goldfish: Fix style issues in macros Message-ID: <20170329071946.GB6503@kroah.com> References: <159caafb-be9c-32d7-9a15-e8593e93ddca@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 345 Lines: 13 On Mon, Mar 27, 2017 at 03:19:06PM +0300, aviyae wrote: > Fix coding style issues in macros: > 1. Add parenthesis around macro arguments > 2. Avoid arguments reuse in macro That's different things, please make different patches for this. Remember, only one patch per "thing" and "fix all style issues" is not "one thing" :) thanks, greg k-h