Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754289AbdC2HfX (ORCPT ); Wed, 29 Mar 2017 03:35:23 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:36079 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753640AbdC2HfT (ORCPT ); Wed, 29 Mar 2017 03:35:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-3-git-send-email-jacopo+renesas@jmondi.org> <20170323160204.GL30223@w540> From: Geert Uytterhoeven Date: Wed, 29 Mar 2017 09:35:17 +0200 X-Google-Sender-Auth: 4Vt5Ep-r1sk_GGgxXxu-v7nobGU Message-ID: Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc To: Linus Walleij Cc: jacopo , Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 58 Hi Linus, On Wed, Mar 29, 2017 at 4:30 AM, Linus Walleij wrote: > On Tue, Mar 28, 2017 at 4:38 PM, wrote: >>> The fact that historically all the early adopters of pinctrl in device >>> tree >>> have these funky custom bindings is unfortunate but just something >>> that we need to live with. >> >> To avoid any confusion, please bear with me and clarify this once and for >> all, >> since I'm not certain I fully got you here. >> >> Are you suggesting: >> >> 1) Use "pins" property with the currently implemented ABI (which slightly >> differs >> from the standard documented one as explained above. Not sure it is fine >> overriding >> it or not) > > Correction: you should be using the property "pinmux", because you > are setting group and function at the same time. OK. > See for example: > include/dt-bindings/pinctrl/mt65xx.h > > And how that is used in: > arch/arm/boot/dts/mt2701-pinfunc.h > arch/arm/boot/dts/mt2701-evb.dts > > The docs are here: > Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt All of the above pack the information for a pin into a single 32-bit integer. Is that what you want us to use, too? Currently we use two integers: 1) pin index, and 2) function/flags combo. > I'm sorry that "pinmux" is not part of the generic documentation, it'd be > great if you would like to add it with a patch. That would mean pinmux could be an array of single values, or tuples. Is that OK? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds