Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754168AbdC2HiC (ORCPT ); Wed, 29 Mar 2017 03:38:02 -0400 Received: from mail-ot0-f169.google.com ([74.125.82.169]:33351 "EHLO mail-ot0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753721AbdC2Hh7 (ORCPT ); Wed, 29 Mar 2017 03:37:59 -0400 MIME-Version: 1.0 In-Reply-To: <20170327131825.32134-4-juri.lelli@arm.com> References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-4-juri.lelli@arm.com> From: Vincent Guittot Date: Wed, 29 Mar 2017 09:37:37 +0200 Message-ID: Subject: Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity To: Juri Lelli Cc: linux-kernel , "linux-pm@vger.kernel.org" , LAK , "devicetree@vger.kernel.org" , Peter Zijlstra , Rob Herring , Mark Rutland , Russell King - ARM Linux , Sudeep Holla , Lorenzo Pieralisi , Catalin Marinas , Will Deacon , Morten Rasmussen , Dietmar Eggemann , Mark Brown , "gregkh@linuxfoundation.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 34 On 27 March 2017 at 15:18, Juri Lelli wrote: > parse_cpu_capacity() has to return 0 on failure, but it currently returns > 1 instead if raw_capacity kcalloc failed. > > Fix it by removing the negation of the return value. > > Cc: Russell King > Reported-by: Morten Rasmussen > Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT') > Signed-off-by: Juri Lelli > --- > arch/arm/kernel/topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index f8a3ab82e77f..4e4af809606a 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu) > if (!raw_capacity) { > pr_err("cpu_capacity: failed to allocate memory for raw capacities\n"); > cap_parsing_failed = true; > - return !ret; > + return ret; Why not directly returning 0 ? whatever the value of ret, the parse of cpu capacity has failed in this case > } > } > capacity_scale = max(cpu_capacity, capacity_scale); > -- > 2.10.0 >