Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754424AbdC2Hj0 (ORCPT ); Wed, 29 Mar 2017 03:39:26 -0400 Received: from mail-ot0-f177.google.com ([74.125.82.177]:35708 "EHLO mail-ot0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754262AbdC2HjX (ORCPT ); Wed, 29 Mar 2017 03:39:23 -0400 MIME-Version: 1.0 In-Reply-To: <20170327131825.32134-5-juri.lelli@arm.com> References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-5-juri.lelli@arm.com> From: Vincent Guittot Date: Wed, 29 Mar 2017 09:39:01 +0200 Message-ID: Subject: Re: [PATCH v3 4/9] arm: remove wrong CONFIG_PROC_SYSCTL ifdef To: Juri Lelli Cc: linux-kernel , "linux-pm@vger.kernel.org" , LAK , "devicetree@vger.kernel.org" , Peter Zijlstra , Rob Herring , Mark Rutland , Russell King - ARM Linux , Sudeep Holla , Lorenzo Pieralisi , Catalin Marinas , Will Deacon , Morten Rasmussen , Dietmar Eggemann , Mark Brown , "gregkh@linuxfoundation.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 40 On 27 March 2017 at 15:18, Juri Lelli wrote: > The sysfs cpu_capacity entry for each CPU has nothing to do with > PROC_FS, nor it's in /proc/sys path. > > Remove such ifdef. > > Cc: Russell King > Reported-and-suggested-by: Sudeep Holla > Fixes: 7e5930aaef5d ('ARM: 8622/3: add sysfs cpu_capacity attribute') > Signed-off-by: Juri Lelli Acked-by: Vincent Guittot > --- > arch/arm/kernel/topology.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > index 4e4af809606a..162c82aeed96 100644 > --- a/arch/arm/kernel/topology.c > +++ b/arch/arm/kernel/topology.c > @@ -57,7 +57,6 @@ static void set_capacity_scale(unsigned int cpu, unsigned long capacity) > per_cpu(cpu_scale, cpu) = capacity; > } > > -#ifdef CONFIG_PROC_SYSCTL > static ssize_t cpu_capacity_show(struct device *dev, > struct device_attribute *attr, > char *buf) > @@ -114,7 +113,6 @@ static int register_cpu_capacity_sysctl(void) > return 0; > } > subsys_initcall(register_cpu_capacity_sysctl); > -#endif > > #ifdef CONFIG_OF > struct cpu_efficiency { > -- > 2.10.0 >