MIME-Version: 1.0
In-Reply-To: <20170327131825.32134-5-juri.lelli@arm.com>
References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-5-juri.lelli@arm.com>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Wed, 29 Mar 2017 09:39:01 +0200
Message-ID: <CAKfTPtBSFVsRGGFGg2oJF=FN5X6XTp7VtpCLORdEL0GqM+cKXQ@mail.gmail.com>
Subject: Re: [PATCH v3 4/9] arm: remove wrong CONFIG_PROC_SYSCTL ifdef
To: Juri Lelli <juri.lelli@arm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        LAK <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Mark Brown <broonie@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1307
Lines: 40

On 27 March 2017 at 15:18, Juri Lelli <juri.lelli@arm.com> wrote:
> The sysfs cpu_capacity entry for each CPU has nothing to do with
> PROC_FS, nor it's in /proc/sys path.
>
> Remove such ifdef.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Reported-and-suggested-by: Sudeep Holla <sudeep.holla@arm.com>
> Fixes: 7e5930aaef5d ('ARM: 8622/3: add sysfs cpu_capacity attribute')
> Signed-off-by: Juri Lelli <juri.lelli@arm.com>

Acked-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  arch/arm/kernel/topology.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> index 4e4af809606a..162c82aeed96 100644
> --- a/arch/arm/kernel/topology.c
> +++ b/arch/arm/kernel/topology.c
> @@ -57,7 +57,6 @@ static void set_capacity_scale(unsigned int cpu, unsigned long capacity)
>         per_cpu(cpu_scale, cpu) = capacity;
>  }
>
> -#ifdef CONFIG_PROC_SYSCTL
>  static ssize_t cpu_capacity_show(struct device *dev,
>                                  struct device_attribute *attr,
>                                  char *buf)
> @@ -114,7 +113,6 @@ static int register_cpu_capacity_sysctl(void)
>         return 0;
>  }
>  subsys_initcall(register_cpu_capacity_sysctl);
> -#endif
>
>  #ifdef CONFIG_OF
>  struct cpu_efficiency {
> --
> 2.10.0
>