Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754837AbdC2IGO (ORCPT ); Wed, 29 Mar 2017 04:06:14 -0400 Received: from foss.arm.com ([217.140.101.70]:58152 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754742AbdC2IGL (ORCPT ); Wed, 29 Mar 2017 04:06:11 -0400 Date: Wed, 29 Mar 2017 09:06:03 +0100 From: Juri Lelli To: Vincent Guittot Cc: linux-kernel , "linux-pm@vger.kernel.org" , LAK , "devicetree@vger.kernel.org" , Peter Zijlstra , Rob Herring , Mark Rutland , Russell King - ARM Linux , Sudeep Holla , Lorenzo Pieralisi , Catalin Marinas , Will Deacon , Morten Rasmussen , Dietmar Eggemann , Mark Brown , "gregkh@linuxfoundation.org" Subject: Re: [PATCH v3 3/9] arm: fix return value of parse_cpu_capacity Message-ID: <20170329080603.GV10289@e106622-lin> References: <20170327131825.32134-1-juri.lelli@arm.com> <20170327131825.32134-4-juri.lelli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 35 On 29/03/17 09:37, Vincent Guittot wrote: > On 27 March 2017 at 15:18, Juri Lelli wrote: > > parse_cpu_capacity() has to return 0 on failure, but it currently returns > > 1 instead if raw_capacity kcalloc failed. > > > > Fix it by removing the negation of the return value. > > > > Cc: Russell King > > Reported-by: Morten Rasmussen > > Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT') > > Signed-off-by: Juri Lelli > > --- > > arch/arm/kernel/topology.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c > > index f8a3ab82e77f..4e4af809606a 100644 > > --- a/arch/arm/kernel/topology.c > > +++ b/arch/arm/kernel/topology.c > > @@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu) > > if (!raw_capacity) { > > pr_err("cpu_capacity: failed to allocate memory for raw capacities\n"); > > cap_parsing_failed = true; > > - return !ret; > > + return ret; > > Why not directly returning 0 ? whatever the value of ret, the parse of > cpu capacity has failed in this case > Sure, can change that. Thanks, - Juri